[dm-devel] [PATCH 08/12] libmultipath(coverity): fix "enum misuse" for find_multipaths

[Benjamin Marzinski]

On Tue, Jan 08, 2019 at 11:54:05PM +0100, Martin Wilck wrote:
> Signed-off-by: Martin Wilck <mwilck at suse.com>
> ---
>  libmultipath/dict.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libmultipath/dict.c b/libmultipath/dict.c
> index fd29abc..eaad4f1 100644
> --- a/libmultipath/dict.c
> +++ b/libmultipath/dict.c
> @@ -327,7 +327,7 @@ def_find_multipaths_handler(struct config *conf, vector strvec)
>  	int i;
>  
>  	if (set_yes_no_undef(strvec, &conf->find_multipaths) == 0 &&
> -	    conf->find_multipaths != YNU_UNDEF)
> +	    conf->find_multipaths != FIND_MULTIPATHS_UNDEF)
>  		return 0;

Is there some reason that I don't understand why YNU_UNDEF is
problematic here, but not later in the function at the:

        if (conf->find_multipaths == YNU_UNDEF) {
                condlog(0, "illegal value for find_multipaths: %s", buff);
                conf->find_multipaths = DEFAULT_FIND_MULTIPATHS;
        }

check?

-Ben

>  
>  	buff = set_value(strvec);
> -- 
> 2.19.2