[dm-devel] block: Fix a WRITE SAME BUG_ON
zhangxiaoxu (A)
zhangxiaoxu5 at huawei.com
Wed Jan 30 06:50:32 UTC 2019
On 1/29/2019 4:52 PM, Christoph Hellwig wrote:
> On Mon, Jan 28, 2019 at 11:54:08PM -0500, Martin K. Petersen wrote:
>> That said, now that we have REQ_OP_WRITE_ZEROES (where the LBS is
>> irrelevant due to the payload being the ZERO_PAGE), it may be worthwhile
>> to remove REQ_OP_WRITE_SAME. I think drbd is the only user relying on a
>> non-zero payload. The target code ends up manually iterating, if I
>> remember correctly...
>
> I had a series to remove it a while ago, but you wanted to keep it at
> that point. I can resurrect it.
>
Do you mean to remove the `blkdev_issue_write_same` interface?
I think we should fix the problem first because other users may also encounter
the same problem.
> .
>
More information about the dm-devel
mailing list