[dm-devel] [PATCH 1/1] kpartx: Use __kernel_daddr_t for solaris_x86_slice.s_start

[Petr Vorel]

Hi Christoph,

> > -//typedef int daddr_t;		/* or long - check */
> > -
> >  struct solaris_x86_slice {
> >  	unsigned short	s_tag;		/* ID tag of partition */
> >  	unsigned short	s_flag;		/* permission flags */
> > -	long		s_start;	/* start sector no of partition */
> > +	__kernel_daddr_t s_start;	/* start sector no of partition */
> >  	long		s_size;		/* # of blocks in partition */
> >  };

> What this really should use is fixed size types.
If it's not specific to __kernel_daddr_t nor daddr_t ("The type of a disk
address") and long is sufficient for all platforms, that's even better.

I'd be just for removing typedef int daddr_t comment.

BTW gpart also uses struct solaris_x86_slice, with daddr_t [1].
I've filed a PR [2], but I guess I'll change it to long.

Kind regards,
Petr

[1] https://github.com/baruch/gpart/blob/master/src/gm_s86dl.h#L43
[2] https://github.com/baruch/gpart/pull/15