[dm-devel] [PATCH 1/1] kpartx: Use __kernel_daddr_t for solaris_x86_slice.s_start

[Christoph Hellwig]

On Tue, Jul 09, 2019 at 10:02:05AM +0200, Petr Vorel wrote:
> 
> > What this really should use is fixed size types.
> If it's not specific to __kernel_daddr_t nor daddr_t ("The type of a disk
> address") and long is sufficient for all platforms, that's even better.
> 
> I'd be just for removing typedef int daddr_t comment.
> 
> BTW gpart also uses struct solaris_x86_slice, with daddr_t [1].
> I've filed a PR [2], but I guess I'll change it to long.

solaris_x86_slice is an on-disk format, defined for good old 32-bit
x86 Solaris.  So the question is not if it is enough, but if it matches
what Solaris does.  I don't have the Solaris source at the moment,
but here is what the Linux kernel uses:

struct solaris_x86_slice {
        __le16 s_tag;           /* ID tag of partition */
        __le16 s_flag;          /* permission flags */
        __le32 s_start;         /* start sector no of partition */
        __le32 s_size;          /* # of blocks in partition */
};