[dm-devel] [PATCH] multipath: call store_pathinfo with DI_BLACKLIST

Martin Wilck mwilck at suse.de
Tue Jun 4 08:28:40 UTC 2019


On Mon, 2019-06-03 at 14:29 -0500, Benjamin Marzinski wrote:
> Commit ca19f865f moved adding DI_BLACKLIST to the pathinfo flags out
> of
> store_pathinfo(), but it didn't add it to all of the necessary
> callers.
> Without this, store_pathinfo() callers can do unnecessary extra work,
> including running the path checker on blacklisted devices. Also,
> running
> 
> multipathd add path <blacklisted_path_device>
> 
> will add a blacklisted path.
> 
> Fixes: ca19f865f "libmultipath: add 'cmd' as argument for
> get_refwwid()"
> Cc: Hannes Reinecke <hare at suse.com>
> Signed-off-by: Benjamin Marzinski <bmarzins at redhat.com>
> ---
>  libmultipath/discovery.c  | 3 ++-
>  multipathd/cli_handlers.c | 2 +-
>  2 files changed, 3 insertions(+), 2 deletions(-)

Reviewed-by: Martin Wilck <mwilck at suse.com>





More information about the dm-devel mailing list