[dm-devel] [PATCH 17/30] libmultipath: fix another WWID overflow in parse_vpd_pg83()
Martin Wilck
mwilck at suse.com
Fri Jun 7 13:05:39 UTC 2019
This one is an obvious typo.
Fixes: 18176202e75c "Read wwid from sysfs vpg_pg83 attribute"
Signed-off-by: Martin Wilck <mwilck at suse.com>
---
libmultipath/discovery.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libmultipath/discovery.c b/libmultipath/discovery.c
index eed35284..10306b22 100644
--- a/libmultipath/discovery.c
+++ b/libmultipath/discovery.c
@@ -1040,7 +1040,7 @@ parse_vpd_pg83(const unsigned char *in, size_t in_len,
len = 1;
vpd += 4;
vpd_len -= 4;
- if (vpd_len > out_len + 2)
+ if (vpd_len > out_len - 2)
vpd_len = out_len - 2;
memcpy(out, vpd, vpd_len);
len = vpd_len + 1;
--
2.21.0
More information about the dm-devel
mailing list