[dm-devel] [PATCH v2 23/30] libmultipath: parse_vpd_pg80: fix overflow output

Martin Wilck mwilck at suse.com
Mon Jun 24 09:27:49 UTC 2019


"vpd pg80 overflow, 20/20 bytes required" looks weird. Make it clear
that actually 21 bytes are required in this case.

Signed-off-by: Martin Wilck <mwilck at suse.com>
---
 libmultipath/discovery.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libmultipath/discovery.c b/libmultipath/discovery.c
index efcea468..931a676f 100644
--- a/libmultipath/discovery.c
+++ b/libmultipath/discovery.c
@@ -912,7 +912,7 @@ parse_vpd_pg80(const unsigned char *in, char *out, size_t out_len)
 
 	if (len >= out_len) {
 		condlog(2, "vpd pg80 overflow, %d/%d bytes required",
-			len, (int)out_len);
+			len + 1, (int)out_len);
 		len = out_len - 1;
 	}
 	if (len > 0) {
-- 
2.21.0




More information about the dm-devel mailing list