[dm-devel] [PATCH v2 8/9] libmultipath: check_rdac(): pre-check in hwtable

[Martin Wilck]

On Mon, 2019-03-18 at 10:52 +0100, Martin Wilck wrote:
> On Mon, 2019-03-18 at 08:10 +0100, Hannes Reinecke w
> > *origin? dummy for do_set_from_hwe()?
> > What funky interface is that?
> > 
> > Please redesign do_set_from_hwe() so as _not_ to require 'magic'
> > variables.
> 
> It's the truly "funky" way the macros are written in dict.c :-/
> (Admittedly I wrote that one myself, but I was following the style of
> the file).
> 
> But you're right, I don't like this "dummy" stuff either. As this
> patch
> set is meant as a bug fix and not a major redesign of dict.c, I guess
> I'll rather not use the do_set_from_hwe() macro there. And put the
> redesign on my to-do list.

... I meant propsel.c, of course. Sorry.

Martin