[dm-devel] [PATCH v2 11/12] libmultipath: add get_uid fallback code for NVMe devices

Benjamin Marzinski bmarzins at redhat.com
Tue Mar 19 17:15:18 UTC 2019


On Fri, Mar 15, 2019 at 12:49:41PM +0100, Martin Wilck wrote:
> On Fri, 2019-03-08 at 17:12 -0600, Benjamin Marzinski wrote:
> > If multipath can't get the uid for NVMe devices from udev, it can get
> > it
> > directly from sysfs.
> > 
> > Signed-off-by: Benjamin Marzinski <bmarzins at redhat.com>
> > ---
> >  libmultipath/discovery.c | 49 ++++++++++++++++++++++++++++--------
> > ----
> >  1 file changed, 34 insertions(+), 15 deletions(-)
> 
> Aside the nit over the "old_len" variable name that I remarked on
> 07/12:

Sure, assuming that we come to some agreement that keeps the fallback
code.

-Ben

> Reviewed-by: Martin Wilck <mwilck at suse.com>
> 
> -- 
> Dr. Martin Wilck <mwilck at suse.com>, Tel. +49 (0)911 74053 2107
> SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton
> HRB 21284 (AG Nürnberg)
> 




More information about the dm-devel mailing list