[dm-devel] [PATCH] dax: Arrange for dax_supported check to span multiple devices

Pankaj Gupta pagupta at redhat.com
Wed May 15 08:38:06 UTC 2019

> Pankaj reports that starting with commit ad428cdb525a "dax: Check the
> end of the block-device capacity with dax_direct_access()" device-mapper
> no longer allows dax operation. This results from the stricter checks in
> __bdev_dax_supported() that validate that the start and end of a
> block-device map to the same 'pagemap' instance.
> Teach the dax-core and device-mapper to validate the 'pagemap' on a
> per-target basis. This is accomplished by refactoring the
> bdev_dax_supported() internals into generic_fsdax_supported() which
> takes a sector range to validate. Consequently generic_fsdax_supported()
> is suitable to be used in a device-mapper ->iterate_devices() callback.
> A new ->dax_supported() operation is added to allow composite devices to
> split and route upper-level bdev_dax_supported() requests.
> Fixes: ad428cdb525a ("dax: Check the end of the block-device...")
> Cc: <stable at vger.kernel.org>
> Cc: Jan Kara <jack at suse.cz>
> Cc: Ira Weiny <ira.weiny at intel.com>
> Cc: Dave Jiang <dave.jiang at intel.com>
> Cc: Mike Snitzer <snitzer at redhat.com>
> Cc: Keith Busch <keith.busch at intel.com>
> Cc: Matthew Wilcox <willy at infradead.org>
> Cc: Vishal Verma <vishal.l.verma at intel.com>
> Cc: Heiko Carstens <heiko.carstens at de.ibm.com>
> Cc: Martin Schwidefsky <schwidefsky at de.ibm.com>
> Reported-by: Pankaj Gupta <pagupta at redhat.com>
> Signed-off-by: Dan Williams <dan.j.williams at intel.com>

Thank you for the patch. Looks good to me. 
I also tested the patch and it works well.

Reviewed-and-Tested-by: Pankaj Gupta <pagupta at redhat.com> 

Best regards,

More information about the dm-devel mailing list