[dm-devel] [PATCH 2/5] libmultipath: dict.c: rename duplicate set_no_path_retry()

Benjamin Marzinski bmarzins at redhat.com
Tue Nov 19 22:30:53 UTC 2019


On Fri, Nov 15, 2019 at 02:41:48PM +0000, Martin Wilck wrote:
> From: Martin Wilck <mwilck at suse.com>
> 
> We have two functions called set_no_path_retry(). Fix that by
> renaming the function in dict.c to no_path_retry_helper().
> 
Reviewed-by: Benjamin Marzinski <bmarzins at redhat.com>
> Signed-off-by: Martin Wilck <mwilck at suse.com>
> ---
>  libmultipath/dict.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/libmultipath/dict.c b/libmultipath/dict.c
> index a90690fa..e8a5ecb2 100644
> --- a/libmultipath/dict.c
> +++ b/libmultipath/dict.c
> @@ -1099,7 +1099,7 @@ declare_mp_handler(pgfailback, set_pgfailback)
>  declare_mp_snprint(pgfailback, print_pgfailback)
>  
>  static int
> -set_no_path_retry(vector strvec, void *ptr)
> +no_path_retry_helper(vector strvec, void *ptr)
>  {
>  	int *int_ptr = (int *)ptr;
>  	char * buff;
> @@ -1134,13 +1134,13 @@ print_no_path_retry(char * buff, int len, long v)
>  	}
>  }
>  
> -declare_def_handler(no_path_retry, set_no_path_retry)
> +declare_def_handler(no_path_retry, no_path_retry_helper)
>  declare_def_snprint(no_path_retry, print_no_path_retry)
> -declare_ovr_handler(no_path_retry, set_no_path_retry)
> +declare_ovr_handler(no_path_retry, no_path_retry_helper)
>  declare_ovr_snprint(no_path_retry, print_no_path_retry)
> -declare_hw_handler(no_path_retry, set_no_path_retry)
> +declare_hw_handler(no_path_retry, no_path_retry_helper)
>  declare_hw_snprint(no_path_retry, print_no_path_retry)
> -declare_mp_handler(no_path_retry, set_no_path_retry)
> +declare_mp_handler(no_path_retry, no_path_retry_helper)
>  declare_mp_snprint(no_path_retry, print_no_path_retry)
>  
>  static int
> -- 
> 2.24.0




More information about the dm-devel mailing list