[dm-devel] [PATCH 1/1] kpartx: Use __kernel_daddr_t for solaris_x86_slice.s_start

Petr Vorel petr.vorel at gmail.com
Sat Oct 12 19:08:36 UTC 2019


Hi Baruch,

> Hi,

> The patch looks good to me, as for gpart, I needed it so I've taken the
> bits and pieces that floated around and merged them all into one place from
> all distributions that I could find.   As for users, in Debian the number
> of users is around 250 so it's a very low usage program but I guess that
> would always be unless very many people lost their partitions every day :-)

> https://qa.debian.org/popcon-graph.php?packages=gpart

> Cheers,
> Baruch

> P.S. While I'm sort of maintaining the program, it's only maintenance, no
> active development is going on with it and very rarely do I get a patch or
> an issue reported.

Thanks for info. FYI (even you don't do active development), although this patch
was merged, it's IMHO wrong approach.
I've sent better approach [1] and I'm going to send v2, which uses uint{16,32}_t
instead of uint{16,32}_t (fixed size types are good enough).
I'll Cc you in new patch, but feel free to ignore it.

Kind regards,
Petr

[1] https://www.redhat.com/archives/dm-devel/2019-October/msg00058.html




More information about the dm-devel mailing list