[dm-devel] [PATCH 45/72] libmultipath: fix -Wsign-compare warnings with snprintf()
Martin Wilck
Martin.Wilck at suse.com
Wed Oct 23 09:11:04 UTC 2019
Hello Bart,
On Tue, 2019-10-22 at 14:32 -0700, Bart Van Assche wrote:
> I'd like to reiterate that introducing -Wsign-compare seems dubious
> to me.
While I disagree with this general statement, I now realized that
my approach to use (int) casts in this specific patch was indeed wrong,
because it prevents detection of negative snprintf() return values.
I'm going to rework this patch.
Regards,
Martin
More information about the dm-devel
mailing list