[dm-devel] [PATCH v4 2/2] mdadm: Introduce new array state 'broken' for raid0/linear
Guilherme G. Piccoli
gpiccoli at canonical.com
Mon Sep 30 19:40:05 UTC 2019
On 30/09/2019 16:36, Jes Sorensen wrote:
> [...]
> Applied thanks!
>
> I fixed up one minor nit rather than having to do the merry-go-round by
> email one more time:
>
>> diff --git a/Monitor.c b/Monitor.c
>> index 036103f..cf0610b 100644
>> --- a/Monitor.c
>> +++ b/Monitor.c
> [snip]
>
>> @@ -1116,7 +1119,8 @@ int WaitClean(char *dev, int verbose)
>> rv = read(state_fd, buf, sizeof(buf));
>> if (rv < 0)
>> break;
>> - if (sysfs_match_word(buf, clean_states) <= 4)
>> + if (sysfs_match_word(buf, clean_states)
>> + < (int)ARRAY_SIZE(clean_states)-1)
>
> I moved the < up to the correct line where it belongs, and added spaces
> ") - 1)"
>
> Cheers,
> Jes
Thanks a lot Jes, much appreciated!
Cheers,
Guilherme
More information about the dm-devel
mailing list