[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [dm-devel] [PATCH 1/4] mpathpersist: remove broken/unused code



On Tue, 2019-09-10 at 17:39 -0500, Benjamin Marzinski wrote:
> The test for an empty pp->dev in updatepaths() dates back to when
> disassemble_map() didn't fill in pp->dev for newly added paths, and
> it
> was meant to catch paths that got added by disassemble_map().  With
> the
> mpathpersist speedup code, all paths get added by disassemble_map().
> However, disassemble_map() now calls devt2devname() to set pp->dev if
> possible.  This means that there is no point in calling
> devt2devname()
> again in updatepaths(). If for some reason it did return success, the
> current code would still fail, since it doesn't set pp->udev in this
> code path. The best thing to do if disassemble_map() couldn't set
> pp->dev is simply to fail the path.
> 
> Signed-off-by: Benjamin Marzinski <bmarzins redhat com>
> ---
>  libmpathpersist/mpath_persist.c | 16 ++++------------
>  1 file changed, 4 insertions(+), 12 deletions(-)

Reviewed-by: Martin Wilck <mwilck suse com>



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]