[dm-devel] [PATCH 13/13] dm-zoned: metadata version 2
Hannes Reinecke
hare at suse.de
Thu Apr 30 14:45:05 UTC 2020
On 4/28/20 12:54 PM, Damien Le Moal wrote:
> On 2020/04/20 19:09, Hannes Reinecke wrote:
>> Implement handling for metadata version 2. The new metadata adds
>> a label and UUID for the device mapper device, and additional UUID
>> for the underlying block devices.
>> It also allows for an additional regular drive to be used for
>> emulating random access zones. The emulated zones will be placed
>> logically in front of the zones from the zoned block device, causing
>> the superblocks and metadata to be stored on that device.
>> The first zone of the original zoned device will be used to hold
>> another, tertiary copy of the metadata; this copy carries a
>> generation number of 0 and is never updated; it's just used
>> for identification.
>>
>> Signed-off-by: Hannes Reinecke <hare at suse.de>
>> Reviewed-by: Bob Liu <bob.liu at oracle.com>
>> ---
>> drivers/md/dm-zoned-metadata.c | 314 ++++++++++++++++++++++++++++++++++-------
>> drivers/md/dm-zoned-target.c | 156 +++++++++++++-------
>> drivers/md/dm-zoned.h | 12 +-
>> 3 files changed, 373 insertions(+), 109 deletions(-)
>>
>> diff --git a/drivers/md/dm-zoned-metadata.c b/drivers/md/dm-zoned-metadata.c
>> index c009f2d962e2..1f31635aba73 100644
>> --- a/drivers/md/dm-zoned-metadata.c
>> +++ b/drivers/md/dm-zoned-metadata.c
>> @@ -16,7 +16,7 @@
>> /*
>> * Metadata version.
>> */
>> -#define DMZ_META_VER 1
>> +#define DMZ_META_VER 2
>>
>> /*
>> * On-disk super block magic.
>> @@ -69,8 +69,17 @@ struct dmz_super {
>> /* Checksum */
>> __le32 crc; /* 48 */
>>
>> + /* DM-Zoned label */
>> + u8 dmz_label[32]; /* 80 */
>> +
>> + /* DM-Zoned UUID */
>> + u8 dmz_uuid[16]; /* 96 */
>> +
>> + /* Device UUID */
>> + u8 dev_uuid[16]; /* 112 */
>> +
>> /* Padding to full 512B sector */
>> - u8 reserved[464]; /* 512 */
>> + u8 reserved[400]; /* 512 */
>> };
>>
>> /*
>> @@ -133,8 +142,11 @@ struct dmz_sb {
>> */
>> struct dmz_metadata {
>> struct dmz_dev *dev;
>> + unsigned int nr_devs;
>>
>> char devname[BDEVNAME_SIZE];
>> + char label[BDEVNAME_SIZE];
>> + uuid_t uuid;
>>
>> sector_t zone_bitmap_size;
>> unsigned int zone_nr_bitmap_blocks;
>> @@ -161,8 +173,9 @@ struct dmz_metadata {
>> /* Zone information array */
>> struct dm_zone *zones;
>>
>> - struct dmz_sb sb[2];
>> + struct dmz_sb sb[3];
>> unsigned int mblk_primary;
>> + unsigned int sb_version;
>> u64 sb_gen;
>> unsigned int min_nr_mblks;
>> unsigned int max_nr_mblks;
>> @@ -195,31 +208,56 @@ struct dmz_metadata {
>> };
>>
>> #define dmz_zmd_info(zmd, format, args...) \
>> - DMINFO("(%s): " format, (zmd)->devname, ## args)
>> + DMINFO("(%s): " format, (zmd)->label, ## args)
>>
>> #define dmz_zmd_err(zmd, format, args...) \
>> - DMERR("(%s): " format, (zmd)->devname, ## args)
>> + DMERR("(%s): " format, (zmd)->label, ## args)
>>
>> #define dmz_zmd_warn(zmd, format, args...) \
>> - DMWARN("(%s): " format, (zmd)->devname, ## args)
>> + DMWARN("(%s): " format, (zmd)->label, ## args)
>>
>> #define dmz_zmd_debug(zmd, format, args...) \
>> - DMDEBUG("(%s): " format, (zmd)->devname, ## args)
>> + DMDEBUG("(%s): " format, (zmd)->label, ## args)
>> /*
>> * Various accessors
>> */
>> +unsigned int dmz_dev_zone_id(struct dmz_metadata *zmd, struct dm_zone *zone)
>> +{
>> + unsigned int zone_id;
>> +
>> + if (WARN_ON(!zone))
>> + return 0;
>> +
>> + zone_id = zone->id;
>> + if (zmd->nr_devs > 1 &&
>> + (zone_id >= zmd->dev[1].zone_offset))
>> + zone_id -= zmd->dev[1].zone_offset;
>
> We could have this as:
>
> if (zone_id >= zmd->dev[0].nr_zones)
> zone_id -= zmd->dev[0].nr_zones;
>
> No ? It is simpler and we can kill the zone_offset.
>
Yes, but it will make the device arrangement implicit; by specifying
the block offset we allow us the option of possibly moving the block
offset into the metadata, and then having the metadata specifying the
layout.
Something which I'd like to keep as I have this weird idea of using
other, non-standard, drives, too, which then would require a more
complex layout.
>> + return zone_id;
>> +}
>> +
>> sector_t dmz_start_sect(struct dmz_metadata *zmd, struct dm_zone *zone)
>> {
>> - return (sector_t)zone->id << zmd->zone_nr_sectors_shift;
>> + unsigned int zone_id = dmz_dev_zone_id(zmd, zone);
>> +
>> + return (sector_t)zone_id << zmd->zone_nr_sectors_shift;
>> }
>>
>> sector_t dmz_start_block(struct dmz_metadata *zmd, struct dm_zone *zone)
>> {
>> - return (sector_t)zone->id << zmd->zone_nr_blocks_shift;
>> + unsigned int zone_id = dmz_dev_zone_id(zmd, zone);
>> +
>> + return (sector_t)zone_id << zmd->zone_nr_blocks_shift;
>> }
>>
>> struct dmz_dev *dmz_zone_to_dev(struct dmz_metadata *zmd, struct dm_zone *zone)
>> {
>> + if (WARN_ON(!zone))
>> + return &zmd->dev[0];
>> +
>> + if (zmd->nr_devs > 1 &&
>> + zone->id >= zmd->dev[1].zone_offset)
>> + return &zmd->dev[1];
>> +
>> return &zmd->dev[0];
>
>
> Same here, simpler version:
>
> if (zone_id < zmd->dev[0].nr_zones)
> return &zmd->dev[0];
>
> return &zmd->dev[1];
>
Same argument here, too :-)
>> }
>>
>> @@ -275,17 +313,33 @@ unsigned int dmz_nr_unmap_seq_zones(struct dmz_metadata *zmd)
>>
>> const char *dmz_metadata_label(struct dmz_metadata *zmd)
>> {
>> - return (const char *)zmd->devname;
>> + return (const char *)zmd->label;
>> }
>>
>> bool dmz_check_dev(struct dmz_metadata *zmd)
>> {
>> - return dmz_check_bdev(&zmd->dev[0]);
>> + unsigned int i;
>> +
>> + for (i = 0; i < zmd->nr_devs; i++) {
>> + if (!zmd->dev[i].bdev)
>> + continue;
>
> This test is not necessary, no ? Since dev[0] is always set now with your latest
> changes reshuffling the devs index.
>
True. Will be removing it.
>> + if (!dmz_check_bdev(&zmd->dev[i]))
>> + return false;
>> + }
>> + return true;
>> }
>>
>> bool dmz_dev_is_dying(struct dmz_metadata *zmd)
>> {
>> - return dmz_bdev_is_dying(&zmd->dev[0]);
>> + unsigned int i;
>> +
>> + for (i = 0; i < zmd->nr_devs; i++) {
>> + if (!zmd->dev[i].bdev)
>> + continue;
>
> Same here.
>
Ok.
>> + if (dmz_bdev_is_dying(&zmd->dev[i]))
>> + return true;
>> + }
>> + return false;
>> }
>>
>> /*
>> @@ -687,6 +741,9 @@ static int dmz_rdwr_block(struct dmz_dev *dev, int op,
>> struct bio *bio;
>> int ret;
>>
>> + if (WARN_ON(!dev))
>> + return -EIO;
>> +
>> if (dmz_bdev_is_dying(dev))
>> return -EIO;
>>
>> @@ -711,7 +768,8 @@ static int dmz_rdwr_block(struct dmz_dev *dev, int op,
>> */
>> static int dmz_write_sb(struct dmz_metadata *zmd, unsigned int set)
>> {
>> - sector_t block = zmd->sb[set].block;
>> + sector_t sb_block =
>> + zmd->sb[set].zone->id << zmd->zone_nr_blocks_shift;
>
> I think this is safe as set 2 is read-only, so updates are opnly for set 0 and 1
> on dev[0]. But a comment pointing that out would be nice...
>
Indeed, as the 'sb_block' variable here is the _absolute_ block address
(ie encompassing both drives). And as such it's the number written into
the metadata, not the position at which the metadata is written to.
But yes, we do need a comment here.
(This was the bit which took me several iteration to sort out ...)
>> struct dmz_mblock *mblk = zmd->sb[set].mblk;
>> struct dmz_super *sb = zmd->sb[set].sb;
>> struct dmz_dev *dev = zmd->sb[set].dev;
>> @@ -719,11 +777,18 @@ static int dmz_write_sb(struct dmz_metadata *zmd, unsigned int set)
>> int ret;
>>
>> sb->magic = cpu_to_le32(DMZ_MAGIC);
>> - sb->version = cpu_to_le32(DMZ_META_VER);
>> +
>> + sb->version = cpu_to_le32(zmd->sb_version);
>> + if (zmd->sb_version > 1) {
>> + BUILD_BUG_ON(UUID_SIZE != 16);
>> + memcpy(sb->dmz_uuid, &zmd->uuid, UUID_SIZE);
>> + memcpy(sb->dmz_label, zmd->label, BDEVNAME_SIZE);
>> + memcpy(sb->dev_uuid, &dev->uuid, UUID_SIZE);
>
> import_uuid() ?
>
Oh, do we have that? Cool ...
Only it would have to be 'export_uuid()';
but then I just saw that we have that, too...
>> + }
>>
>> sb->gen = cpu_to_le64(sb_gen);
>>
>> - sb->sb_block = cpu_to_le64(block);
>> + sb->sb_block = cpu_to_le64(sb_block);
>> sb->nr_meta_blocks = cpu_to_le32(zmd->nr_meta_blocks);
>> sb->nr_reserved_seq = cpu_to_le32(zmd->nr_reserved_seq);
>> sb->nr_chunks = cpu_to_le32(zmd->nr_chunks);
>> @@ -734,7 +799,8 @@ static int dmz_write_sb(struct dmz_metadata *zmd, unsigned int set)
>> sb->crc = 0;
>> sb->crc = cpu_to_le32(crc32_le(sb_gen, (unsigned char *)sb, DMZ_BLOCK_SIZE));
>>
>> - ret = dmz_rdwr_block(dev, REQ_OP_WRITE, block, mblk->page);
>> + ret = dmz_rdwr_block(dev, REQ_OP_WRITE, zmd->sb[set].block,
>> + mblk->page);
>> if (ret == 0)
>> ret = blkdev_issue_flush(dev->bdev, GFP_NOIO, NULL);
>>
>> @@ -915,6 +981,23 @@ static int dmz_check_sb(struct dmz_metadata *zmd, unsigned int set)
>> u32 crc, stored_crc;
>> u64 gen;
>>
>> + if (le32_to_cpu(sb->magic) != DMZ_MAGIC) {
>> + dmz_dev_err(dev, "Invalid meta magic (needed 0x%08x, got 0x%08x)",
>> + DMZ_MAGIC, le32_to_cpu(sb->magic));
>> + return -ENXIO;
>> + }
>> +
>> + zmd->sb_version = le32_to_cpu(sb->version);
>> + if (zmd->sb_version > DMZ_META_VER) {
>> + dmz_dev_err(dev, "Invalid meta version (needed %d, got %d)",
>> + DMZ_META_VER, zmd->sb_version);
>> + return -EINVAL;
>> + }
>> + if ((zmd->sb_version < 1) && (set == 2)) {
>> + dmz_dev_err(dev, "Tertiary superblocks are not supported");
>> + return -EINVAL;
>> + }
>> +
>> gen = le64_to_cpu(sb->gen);
>> stored_crc = le32_to_cpu(sb->crc);
>> sb->crc = 0;
>> @@ -925,18 +1008,44 @@ static int dmz_check_sb(struct dmz_metadata *zmd, unsigned int set)
>> return -ENXIO;
>> }
>>
>> - if (le32_to_cpu(sb->magic) != DMZ_MAGIC) {
>> - dmz_dev_err(dev, "Invalid meta magic (needed 0x%08x, got 0x%08x)",
>> - DMZ_MAGIC, le32_to_cpu(sb->magic));
>> - return -ENXIO;
>> - }
>> + if (zmd->sb_version > 1) {
>> + uuid_t sb_uuid;
>> +
>> + memcpy(&sb_uuid, sb->dmz_uuid, UUID_SIZE);
>> + if (uuid_is_null(&sb_uuid)) {
>> + dmz_dev_err(dev, "NULL DM-Zoned uuid");
>> + return -ENXIO;
>> + } else if (uuid_is_null(&zmd->uuid)) {
>> + uuid_copy(&zmd->uuid, &sb_uuid);
>> + } else if (!uuid_equal(&zmd->uuid, &sb_uuid)) {
>> + dmz_dev_err(dev, "mismatching DM-Zoned uuid, "
>> + "is %pUl expected %pUl",
>> + &sb_uuid, &zmd->uuid);
>> + return -ENXIO;
>> + }
>> + if (!strlen(zmd->label))
>> + memcpy(zmd->label, sb->dmz_label, BDEVNAME_SIZE);
>> + else if (memcmp(zmd->label, sb->dmz_label, BDEVNAME_SIZE)) {
>> + dmz_dev_err(dev, "mismatching DM-Zoned label, "
>> + "is %s expected %s",
>> + sb->dmz_label, zmd->label);
>> + return -ENXIO;
>> + }
>> + memcpy(&dev->uuid, sb->dev_uuid, UUID_SIZE);
>> + if (uuid_is_null(&dev->uuid)) {
>> + dmz_dev_err(dev, "NULL device uuid");
>> + return -ENXIO;
>> + }
>>
>> - if (le32_to_cpu(sb->version) != DMZ_META_VER) {
>> - dmz_dev_err(dev, "Invalid meta version (needed %d, got %d)",
>> - DMZ_META_VER, le32_to_cpu(sb->version));
>> - return -ENXIO;
>> + if (set == 2) {
>> + if (gen != 0) {
>> + dmz_dev_err(dev, "Invalid generation %llu",
>> + gen);
>> + return -ENXIO;
>> + }
>> + return 0;
>> + }
>> }
>> -
>> nr_meta_zones = (le32_to_cpu(sb->nr_meta_blocks) + zmd->zone_nr_blocks - 1)
>> >> zmd->zone_nr_blocks_shift;
>> if (!nr_meta_zones ||
>> @@ -1185,21 +1294,38 @@ static int dmz_load_sb(struct dmz_metadata *zmd)
>> "Using super block %u (gen %llu)",
>> zmd->mblk_primary, zmd->sb_gen);
>>
>> + if ((zmd->sb_version > 1) && zmd->sb[2].zone) {
>> + zmd->sb[2].block = dmz_start_block(zmd, zmd->sb[2].zone);
>> + zmd->sb[2].dev = dmz_zone_to_dev(zmd, zmd->sb[2].zone);
>> + ret = dmz_get_sb(zmd, 2);
>> + if (ret) {
>> + dmz_dev_err(zmd->sb[2].dev,
>> + "Read tertiary super block failed");
>> + return ret;
>> + }
>> + ret = dmz_check_sb(zmd, 2);
>> + if (ret == -EINVAL)
>> + return ret;
>> + }
>> return 0;
>> }
>>
>> /*
>> * Initialize a zone descriptor.
>> */
>> -static int dmz_init_zone(struct blk_zone *blkz, unsigned int idx, void *data)
>> +static int dmz_init_zone(struct blk_zone *blkz, unsigned int num, void *data)
>> {
>> struct dmz_metadata *zmd = data;
>> + struct dmz_dev *dev = zmd->nr_devs > 1 ? &zmd->dev[1] : &zmd->dev[0];
>> + int idx = num + dev->zone_offset;
>> struct dm_zone *zone = &zmd->zones[idx];
>> - struct dmz_dev *dev = zmd->dev;
>>
>> - /* Ignore the eventual last runt (smaller) zone */
>> if (blkz->len != zmd->zone_nr_sectors) {
>> - if (blkz->start + blkz->len == dev->capacity)
>> + if (zmd->sb_version > 1) {
>> + /* Ignore the eventual runt (smaller) zone */
>> + set_bit(DMZ_OFFLINE, &zone->flags);
>> + return 0;
>> + } else if (blkz->start + blkz->len == dev->capacity)
>> return 0;
>> return -ENXIO;
>> }
>> @@ -1234,16 +1360,46 @@ static int dmz_init_zone(struct blk_zone *blkz, unsigned int idx, void *data)
>> zmd->nr_useable_zones++;
>> if (dmz_is_rnd(zone)) {
>> zmd->nr_rnd_zones++;
>> - if (!zmd->sb[0].zone) {
>> - /* Super block zone */
>> + if (zmd->nr_devs == 1 && !zmd->sb[0].zone) {
>> + /* Primary super block zone */
>> zmd->sb[0].zone = zone;
>> }
>> }
>> + if (zmd->nr_devs > 1 && !zmd->sb[2].zone) {
>> + /* Tertiary superblock zone */
>> + zmd->sb[2].zone = zone;
>> + }
>> }
>>
>> return 0;
>> }
>>
>> +static void dmz_emulate_zones(struct dmz_metadata *zmd, struct dmz_dev *dev)
>> +{
>> + int idx;
>> + sector_t zone_offset = 0;
>> +
>> + for(idx = 0; idx < dev->nr_zones; idx++) {
>> + struct dm_zone *zone = &zmd->zones[idx];
>> +
>> + INIT_LIST_HEAD(&zone->link);
>> + atomic_set(&zone->refcount, 0);
>> + zone->id = idx;
>> + zone->chunk = DMZ_MAP_UNMAPPED;
>> + set_bit(DMZ_RND, &zone->flags);
>> + zone->wp_block = 0;
>> + zmd->nr_rnd_zones++;
>> + zmd->nr_useable_zones++;
>> + if (dev->capacity - zone_offset <
>> + zmd->zone_nr_sectors) {
>
> No need for the line break here. It fits in 80 chars line.
>
ok.
>> + /* Disable runt zone */
>> + set_bit(DMZ_OFFLINE, &zone->flags);
>> + break;
>> + }
>> + zone_offset += zmd->zone_nr_sectors;
>> + }
>> +}
>> +
>> /*
>> * Free zones descriptors.
>> */
>> @@ -1259,11 +1415,11 @@ static void dmz_drop_zones(struct dmz_metadata *zmd)
>> */
>> static int dmz_init_zones(struct dmz_metadata *zmd)
>> {
>> - struct dmz_dev *dev = &zmd->dev[0];
>> - int ret;
>> + int i, ret;
>> + struct dmz_dev *zoned_dev = &zmd->dev[0];
>>
>> /* Init */
>> - zmd->zone_nr_sectors = dev->zone_nr_sectors;
>> + zmd->zone_nr_sectors = zmd->dev[0].zone_nr_sectors;
>> zmd->zone_nr_sectors_shift = ilog2(zmd->zone_nr_sectors);
>> zmd->zone_nr_blocks = dmz_sect2blk(zmd->zone_nr_sectors);
>> zmd->zone_nr_blocks_shift = ilog2(zmd->zone_nr_blocks);
>> @@ -1274,7 +1430,14 @@ static int dmz_init_zones(struct dmz_metadata *zmd)
>> DMZ_BLOCK_SIZE_BITS);
>>
>> /* Allocate zone array */
>> - zmd->nr_zones = dev->nr_zones;
>> + zmd->nr_zones = 0;
>> + for (i = 0; i < zmd->nr_devs; i++)
>> + zmd->nr_zones += zmd->dev[i].nr_zones;
>> +
>> + if (!zmd->nr_zones) {
>> + DMERR("(%s): No zones found", zmd->devname);
>> + return -ENXIO;
>> + }
>
> I tested and this does not work for a single zoned device case because nr_zones
> is set in device fixup after this. So thie sees nr_zones == 0.
>
Right.
>> zmd->zones = kcalloc(zmd->nr_zones, sizeof(struct dm_zone), GFP_KERNEL);
>> if (!zmd->zones)
>> return -ENOMEM;
>> @@ -1282,14 +1445,27 @@ static int dmz_init_zones(struct dmz_metadata *zmd)
>> DMINFO("(%s): Using %zu B for zone information",
>> zmd->devname, sizeof(struct dm_zone) * zmd->nr_zones);
>>
>> + if (zmd->nr_devs > 1) {
>> + dmz_emulate_zones(zmd, &zmd->dev[0]);
>> + /*
>> + * Primary superblock zone is always at zone 0 when multiple
>> + * drives are present.
>> + */
>> + zmd->sb[0].zone = &zmd->zones[0];
>> +
>> + zoned_dev = &zmd->dev[1];
>> + }
>> +
>> /*
>> * Get zone information and initialize zone descriptors. At the same
>> * time, determine where the super block should be: first block of the
>> * first randomly writable zone.
>> */
>> - ret = blkdev_report_zones(dev->bdev, 0, BLK_ALL_ZONES, dmz_init_zone,
>> - zmd);
>> + ret = blkdev_report_zones(zoned_dev->bdev, 0, BLK_ALL_ZONES,
>> + dmz_init_zone, zmd);
>> if (ret < 0) {
>> + DMDEBUG("(%s): Failed to report zones, error %d",
>> + zmd->devname, ret);
>> dmz_drop_zones(zmd);
>> return ret;
>> }
>> @@ -1325,6 +1501,9 @@ static int dmz_update_zone(struct dmz_metadata *zmd, struct dm_zone *zone)
>> unsigned int noio_flag;
>> int ret;
>>
>> + if (dev->flags & DMZ_BDEV_REGULAR)
>> + return 0;
>> +
>> /*
>> * Get zone information from disk. Since blkdev_report_zones() uses
>> * GFP_KERNEL by default for memory allocations, set the per-task
>> @@ -2475,18 +2654,34 @@ void dmz_print_dev(struct dmz_metadata *zmd, int num)
>> {
>> struct dmz_dev *dev = &zmd->dev[num];
>>
>> - dmz_dev_info(dev, "Host-%s zoned block device",
>> - bdev_zoned_model(dev->bdev) == BLK_ZONED_HA ?
>> - "aware" : "managed");
>> - dmz_dev_info(dev, " %llu 512-byte logical sectors",
>> - (u64)dev->capacity);
>> - dmz_dev_info(dev, " %u zones of %llu 512-byte logical sectors",
>> - dev->nr_zones, (u64)zmd->zone_nr_sectors);
>> + if (bdev_zoned_model(dev->bdev) == BLK_ZONED_NONE)
>> + dmz_dev_info(dev, "Regular block device");
>> + else
>> + dmz_dev_info(dev, "Host-%s zoned block device",
>> + bdev_zoned_model(dev->bdev) == BLK_ZONED_HA ?
>> + "aware" : "managed");
>> + if (zmd->sb_version > 1) {
>> + sector_t sector_offset =
>> + dev->zone_offset << zmd->zone_nr_sectors_shift;
>> +
>> + dmz_dev_info(dev, " uuid %pUl", &dev->uuid);
>> + dmz_dev_info(dev, " %llu 512-byte logical sectors (offset %llu)",
>> + (u64)dev->capacity, (u64)sector_offset);
>> + dmz_dev_info(dev, " %u zones of %llu 512-byte logical sectors (offset %llu)",
>> + dev->nr_zones, (u64)zmd->zone_nr_sectors,
>> + (u64)dev->zone_offset);
>> + } else {
>> + dmz_dev_info(dev, " %llu 512-byte logical sectors",
>> + (u64)dev->capacity);
>> + dmz_dev_info(dev, " %u zones of %llu 512-byte logical sectors",
>> + dev->nr_zones, (u64)zmd->zone_nr_sectors);
>> + }
>> }
>> /*
>> * Initialize the zoned metadata.
>> */
>> -int dmz_ctr_metadata(struct dmz_dev *dev, struct dmz_metadata **metadata,
>> +int dmz_ctr_metadata(struct dmz_dev *dev, int num_dev,
>> + struct dmz_metadata **metadata,
>> const char *devname)
>> {
>> struct dmz_metadata *zmd;
>> @@ -2500,6 +2695,7 @@ int dmz_ctr_metadata(struct dmz_dev *dev, struct dmz_metadata **metadata,
>>
>> strcpy(zmd->devname, devname);
>> zmd->dev = dev;
>> + zmd->nr_devs = num_dev;
>> zmd->mblk_rbtree = RB_ROOT;
>> init_rwsem(&zmd->mblk_sem);
>> mutex_init(&zmd->mblk_flush_lock);
>> @@ -2534,11 +2730,24 @@ int dmz_ctr_metadata(struct dmz_dev *dev, struct dmz_metadata **metadata,
>> /* Set metadata zones starting from sb_zone */
>> for (i = 0; i < zmd->nr_meta_zones << 1; i++) {
>> zone = dmz_get(zmd, zmd->sb[0].zone->id + i);
>> - if (!dmz_is_rnd(zone))
>> + if (!dmz_is_rnd(zone)) {
>> + dmz_zmd_err(zmd,
>> + "metadata zone %d is not random", i);
>> + ret = -ENXIO;
>> goto err;
>> + }
>> + set_bit(DMZ_META, &zone->flags);
>> + }
>> + if (zmd->sb[2].zone) {
>> + zone = dmz_get(zmd, zmd->sb[2].zone->id);
>> + if (!zone) {
>> + dmz_zmd_err(zmd,
>> + "Tertiary metadata zone not present");
>> + ret = -ENXIO;
>> + goto err;
>> + }
>> set_bit(DMZ_META, &zone->flags);
>> }
>> -
>> /* Load mapping table */
>> ret = dmz_load_mapping(zmd);
>> if (ret)
>> @@ -2563,8 +2772,13 @@ int dmz_ctr_metadata(struct dmz_dev *dev, struct dmz_metadata **metadata,
>> goto err;
>> }
>>
>> - dmz_zmd_info(zmd, "DM-Zoned metadata version %d", DMZ_META_VER);
>> - dmz_print_dev(zmd, 0);
>> + dmz_zmd_info(zmd, "DM-Zoned metadata version %d", zmd->sb_version);
>> + if (zmd->sb_version > 1) {
>> + dmz_zmd_info(zmd, "DM UUID %pUl", &zmd->uuid);
>> + dmz_zmd_info(zmd, "DM Label %s", zmd->label);
>> + }
>> + for (i = 0; i < zmd->nr_devs; i++)
>> + dmz_print_dev(zmd, i);
>>
>> dmz_zmd_info(zmd, " %u zones of %llu 512-byte logical sectors",
>> zmd->nr_zones, (u64)zmd->zone_nr_sectors);
>> diff --git a/drivers/md/dm-zoned-target.c b/drivers/md/dm-zoned-target.c
>> index 4897ffae96ca..ae05d5d60b37 100644
>> --- a/drivers/md/dm-zoned-target.c
>> +++ b/drivers/md/dm-zoned-target.c
>> @@ -38,7 +38,7 @@ struct dm_chunk_work {
>> * Target descriptor.
>> */
>> struct dmz_target {
>> - struct dm_dev *ddev;
>> + struct dm_dev *ddev[2];
>>
>> unsigned long flags;
>>
>> @@ -684,60 +684,40 @@ static int dmz_map(struct dm_target *ti, struct bio *bio)
>> /*
>> * Get zoned device information.
>> */
>> -static int dmz_get_zoned_device(struct dm_target *ti, char *path)
>> +static int dmz_get_zoned_device(struct dm_target *ti, char *path, int num)
>> {
>> struct dmz_target *dmz = ti->private;
>> - struct request_queue *q;
>> struct dmz_dev *dev;
>> - sector_t aligned_capacity;
>> int ret;
>> + struct block_device *bdev;
>>
>> /* Get the target device */
>> - ret = dm_get_device(ti, path, dm_table_get_mode(ti->table), &dmz->ddev);
>> + ret = dm_get_device(ti, path, dm_table_get_mode(ti->table),
>> + &dmz->ddev[num]);
>> if (ret) {
>> ti->error = "Get target device failed";
>> - dmz->ddev = NULL;
>> + dmz->ddev[num] = NULL;
>> return ret;
>> }
>>
>> - dev = kzalloc(sizeof(struct dmz_dev), GFP_KERNEL);
>> - if (!dev) {
>> - ret = -ENOMEM;
>> - goto err;
>> - }
>> -
>> - dev->bdev = dmz->ddev->bdev;
>> + bdev = dmz->ddev[num]->bdev;
>> + if (bdev_zoned_model(bdev) == BLK_ZONED_NONE) {
>> + dev = &dmz->dev[0];
>> + dev->flags = DMZ_BDEV_REGULAR;
>> + } else
>> + dev = &dmz->dev[1];
>> + dev->bdev = bdev;
>> (void)bdevname(dev->bdev, dev->name);
>
> I changed this. See below.
>
>>
>> - if (bdev_zoned_model(dev->bdev) == BLK_ZONED_NONE) {
>> - ti->error = "Not a zoned block device";
>> - ret = -EINVAL;
>> - goto err;
>> - }
>> -
>> - q = bdev_get_queue(dev->bdev);
>> dev->capacity = i_size_read(dev->bdev->bd_inode) >> SECTOR_SHIFT;
>> - aligned_capacity = dev->capacity &
>> - ~((sector_t)blk_queue_zone_sectors(q) - 1);
>> - if (ti->begin ||
>> - ((ti->len != dev->capacity) && (ti->len != aligned_capacity))) {
>> - ti->error = "Partial mapping not supported";
>> - ret = -EINVAL;
>> - goto err;
>> + if (ti->begin) {
>> + ti->error = "Partial mapping is not supported";
>> + dm_put_device(ti, dmz->ddev[num]);
>> + dmz->ddev[num] = NULL;
>> + return -EINVAL;
>> }
>>
>> - dev->zone_nr_sectors = blk_queue_zone_sectors(q);
>> -
>> - dev->nr_zones = blkdev_nr_zones(dev->bdev->bd_disk);
>> -
>> - dmz->dev = dev;
>> -
>> return 0;
>> -err:
>> - dm_put_device(ti, dmz->ddev);
>> - kfree(dev);
>> -
>> - return ret;
>> }
>>
>> /*
>> @@ -747,9 +727,46 @@ static void dmz_put_zoned_device(struct dm_target *ti)
>> {
>> struct dmz_target *dmz = ti->private;
>>
>> - dm_put_device(ti, dmz->ddev);
>> - kfree(dmz->dev);
>> - dmz->dev = NULL;
>> + if (dmz->ddev[1]) {
>> + dm_put_device(ti, dmz->ddev[1]);
>> + dmz->ddev[1] = NULL;
>> + }
>> + dm_put_device(ti, dmz->ddev[0]);
>> + dmz->ddev[0] = NULL;
>
> A for loop here would be cleaner ?
>
>> +}
>> +
>> +static int dmz_fixup_devices(struct dm_target *ti)
>> +{
>> + struct dmz_target *dmz = ti->private;
>> + struct dmz_dev *pri_dev, *sec_dev;
>> + struct request_queue *q;
>> +
>> + pri_dev = &dmz->dev[0];
>> + if (!(pri_dev->flags & DMZ_BDEV_REGULAR)) {
>> + ti->error = "Primary disk is not a regular device";
>> + return -EINVAL;
>> + }
>> + sec_dev = &dmz->dev[1];
>> + if (sec_dev->flags & DMZ_BDEV_REGULAR) {
>> + ti->error = "Secondary disk is not a zoned device";
>> + return -EINVAL;
>> + }
>> + q = bdev_get_queue(sec_dev->bdev);
>> + sec_dev->zone_nr_sectors = blk_queue_zone_sectors(q);
>> + sec_dev->nr_zones = blkdev_nr_zones(sec_dev->bdev->bd_disk);
>> +
>> + pri_dev->zone_nr_sectors = sec_dev->zone_nr_sectors;
>> + pri_dev->nr_zones = DIV_ROUND_UP(pri_dev->capacity,
>> + pri_dev->zone_nr_sectors);
>> + sec_dev->zone_offset = pri_dev->nr_zones;
>> + /* Check if we need to swizzle devices */
>> + if (pri_dev->bdev != dmz->ddev[0]->bdev) {
>> + struct dm_dev *ddev = dmz->ddev[0];
>> +
>> + dmz->ddev[0] = dmz->ddev[1];
>> + dmz->ddev[1] = ddev;
>> + }
>> + return 0;
>
> Changed this too. See below.
>
>> }
>>
>> /*
>> @@ -758,11 +775,10 @@ static void dmz_put_zoned_device(struct dm_target *ti)
>> static int dmz_ctr(struct dm_target *ti, unsigned int argc, char **argv)
>> {
>> struct dmz_target *dmz;
>> - struct dmz_dev *dev;
>> int ret;
>>
>> /* Check arguments */
>> - if (argc != 1) {
>> + if (argc < 1 || argc > 2) {
>> ti->error = "Invalid argument count";
>> return -EINVAL;
>> }
>> @@ -773,18 +789,34 @@ static int dmz_ctr(struct dm_target *ti, unsigned int argc, char **argv)
>> ti->error = "Unable to allocate the zoned target descriptor";
>> return -ENOMEM;
>> }
>> + dmz->dev = kcalloc(2, sizeof(struct dmz_dev), GFP_KERNEL);
>> + if (!dmz->dev) {
>> + ti->error = "Unable to allocate the zoned device descriptors";
>> + kfree(dmz);
>> + return -ENOMEM;
>> + }
>> ti->private = dmz;
>>
>> /* Get the target zoned block device */
>> - ret = dmz_get_zoned_device(ti, argv[0]);
>> - if (ret) {
>> - dmz->ddev = NULL;
>> + ret = dmz_get_zoned_device(ti, argv[0], 0);
>> + if (ret)
>> goto err;
>> +
>> + if (argc == 2) {
>> + ret = dmz_get_zoned_device(ti, argv[1], 1);
>> + if (ret) {
>> + dmz_put_zoned_device(ti);
>> + goto err;
>> + }
>> + ret = dmz_fixup_devices(ti);
>> + if (ret) {
>> + dmz_put_zoned_device(ti);
>> + goto err;
>> + }
>
> Fixup devices needs to be called regardless of the number of drives so that
> zone_nr_sectors and nr_zones get initialized. See below.
>
>> }
>>
>> /* Initialize metadata */
>> - dev = dmz->dev;
>> - ret = dmz_ctr_metadata(dev, &dmz->metadata,
>> + ret = dmz_ctr_metadata(dmz->dev, argc, &dmz->metadata,
>> dm_table_device_name(ti->table));
>> if (ret) {
>> ti->error = "Metadata initialization failed";
>> @@ -861,6 +893,7 @@ static int dmz_ctr(struct dm_target *ti, unsigned int argc, char **argv)
>> err_dev:
>> dmz_put_zoned_device(ti);
>> err:
>> + kfree(dmz->dev);
>> kfree(dmz);
>>
>> return ret;
>> @@ -891,6 +924,7 @@ static void dmz_dtr(struct dm_target *ti)
>>
>> mutex_destroy(&dmz->chunk_lock);
>>
>> + kfree(dmz->dev);
>> kfree(dmz);
>> }
>>
>> @@ -965,10 +999,17 @@ static int dmz_iterate_devices(struct dm_target *ti,
>> iterate_devices_callout_fn fn, void *data)
>> {
>> struct dmz_target *dmz = ti->private;
>> - struct dmz_dev *dev = dmz->dev;
>> - sector_t capacity = dev->capacity & ~(dmz_zone_nr_sectors(dmz->metadata) - 1);
>> -
>> - return fn(ti, dmz->ddev, 0, capacity, data);
>> + unsigned int zone_nr_sectors = dmz_zone_nr_sectors(dmz->metadata);
>> + sector_t capacity;
>> + int r;
>> +
>> + capacity = dmz->dev[0].capacity & ~(zone_nr_sectors - 1);
>> + r = fn(ti, dmz->ddev[0], 0, capacity, data);
>> + if (!r && dmz->ddev[1]) {
>> + capacity = dmz->dev[1].capacity & ~(zone_nr_sectors - 1);
>> + r = fn(ti, dmz->ddev[1], 0, capacity, data);
>> + }
>> + return r;
>> }
>>
>> static void dmz_status(struct dm_target *ti, status_type_t type,
>> @@ -978,6 +1019,7 @@ static void dmz_status(struct dm_target *ti, status_type_t type,
>> struct dmz_target *dmz = ti->private;
>> ssize_t sz = 0;
>> char buf[BDEVNAME_SIZE];
>> + struct dmz_dev *dev;
>>
>> switch (type) {
>> case STATUSTYPE_INFO:
>> @@ -991,8 +1033,14 @@ static void dmz_status(struct dm_target *ti, status_type_t type,
>> dmz_nr_seq_zones(dmz->metadata));
>> break;
>> case STATUSTYPE_TABLE:
>> - format_dev_t(buf, dmz->dev->bdev->bd_dev);
>> + dev = &dmz->dev[0];
>> + format_dev_t(buf, dev->bdev->bd_dev);
>> DMEMIT("%s ", buf);
>> + if (dmz->dev[1].bdev) {
>> + dev = &dmz->dev[1];
>> + format_dev_t(buf, dev->bdev->bd_dev);
>> + DMEMIT("%s ", buf);
>> + }
>> break;
>> }
>> return;
>> @@ -1014,7 +1062,7 @@ static int dmz_message(struct dm_target *ti, unsigned int argc, char **argv,
>>
>> static struct target_type dmz_type = {
>> .name = "zoned",
>> - .version = {1, 1, 0},
>> + .version = {1, 2, 0},
>
> May be got to version 2.0.0 to match the metadata version number ?
>
Sure. Will be updating it.
>> .features = DM_TARGET_SINGLETON | DM_TARGET_ZONED_HM,
>> .module = THIS_MODULE,
>> .ctr = dmz_ctr,
>> diff --git a/drivers/md/dm-zoned.h b/drivers/md/dm-zoned.h
>> index 454ebd628cca..e383d5b2a3c5 100644
>> --- a/drivers/md/dm-zoned.h
>> +++ b/drivers/md/dm-zoned.h
>> @@ -52,10 +52,12 @@ struct dmz_dev {
>> struct block_device *bdev;
>>
>> char name[BDEVNAME_SIZE];
>> + uuid_t uuid;
>>
>> sector_t capacity;
>>
>> unsigned int nr_zones;
>> + unsigned int zone_offset;
>>
>> unsigned int flags;
>>
>> @@ -69,6 +71,7 @@ struct dmz_dev {
>> /* Device flags. */
>> #define DMZ_BDEV_DYING (1 << 0)
>> #define DMZ_CHECK_BDEV (2 << 0)
>> +#define DMZ_BDEV_REGULAR (4 << 0)
>>
>> /*
>> * Zone descriptor.
>> @@ -163,8 +166,8 @@ struct dmz_reclaim;
>> /*
>> * Functions defined in dm-zoned-metadata.c
>> */
>> -int dmz_ctr_metadata(struct dmz_dev *dev, struct dmz_metadata **zmd,
>> - const char *devname);
>> +int dmz_ctr_metadata(struct dmz_dev *dev, int num_dev,
>> + struct dmz_metadata **zmd, const char *devname);
>> void dmz_dtr_metadata(struct dmz_metadata *zmd);
>> int dmz_resume_metadata(struct dmz_metadata *zmd);
>>
>> @@ -176,15 +179,13 @@ void dmz_lock_flush(struct dmz_metadata *zmd);
>> void dmz_unlock_flush(struct dmz_metadata *zmd);
>> int dmz_flush_metadata(struct dmz_metadata *zmd);
>> const char *dmz_metadata_label(struct dmz_metadata *zmd);
>> +bool dmz_check_dev(struct dmz_metadata *zmd);
>>
>> sector_t dmz_start_sect(struct dmz_metadata *zmd, struct dm_zone *zone);
>> sector_t dmz_start_block(struct dmz_metadata *zmd, struct dm_zone *zone);
>> unsigned int dmz_nr_chunks(struct dmz_metadata *zmd);
>> struct dmz_dev *dmz_zone_to_dev(struct dmz_metadata *zmd, struct dm_zone *zone);
>>
>> -bool dmz_check_dev(struct dmz_metadata *zmd);
>> -bool dmz_dev_is_dying(struct dmz_metadata *zmd);
>> -
>> #define DMZ_ALLOC_RND 0x01
>> #define DMZ_ALLOC_RECLAIM 0x02
>>
>> @@ -251,6 +252,7 @@ int dmz_copy_valid_blocks(struct dmz_metadata *zmd, struct dm_zone *from_zone,
>> struct dm_zone *to_zone);
>> int dmz_merge_valid_blocks(struct dmz_metadata *zmd, struct dm_zone *from_zone,
>> struct dm_zone *to_zone, sector_t chunk_block);
>> +bool dmz_dev_is_dying(struct dmz_metadata *zmd);
>>
>> /*
>> * Functions defined in dm-zoned-reclaim.c
>>
>
> I ran the entire series through simple tests. As noted above, the single drive
> case is broken. Here is what I applied on top of this patch to fix it:
>
I'll give it a spin on my testbed, and will be sending a v4 shortly.
Cheers,
Hannes
--
Dr. Hannes Reinecke Teamlead Storage & Networking
hare at suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer
More information about the dm-devel
mailing list