[dm-devel] [dm- devel][PATCH] vector: fix upper boundary check of vector size in vector_del_slot

[Benjamin Marzinski]

On Mon, Aug 03, 2020 at 10:39:29AM +0800, Zhiqiang Liu wrote:
> 
> In vector_del_slot func, legal value of input slot is in range of
> [0, VECTOR_SIZE(v)), it means slot value should be less then VECTOR_SIZE(v).
> 
> 
> Signed-off-by: Zhiqiang Liu <liuzhiqiang26 at huawei.com>

Reviewed-by: Benjamin Marzinski <bmarzins at redhat.com>

> ---
>  libmultipath/vector.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libmultipath/vector.c b/libmultipath/vector.c
> index 501cf4c5..5b047e40 100644
> --- a/libmultipath/vector.c
> +++ b/libmultipath/vector.c
> @@ -109,7 +109,7 @@ vector_del_slot(vector v, int slot)
>  {
>  	int i;
> 
> -	if (!v || !v->allocated || slot < 0 || slot > VECTOR_SIZE(v))
> +	if (!v || !v->allocated || slot < 0 || slot >= VECTOR_SIZE(v))
>  		return;
> 
>  	for (i = slot + 1; i < VECTOR_SIZE(v); i++)
> -- 
> 2.24.0.windows.2
>