[dm-devel] [PATCH] libmultipath: fix a memory leak in disassemble_status func

[Martin Wilck]

Hi Ben,

On Tue, 2020-07-28 at 11:20 -0500, Benjamin Marzinski wrote:
> On Tue, Jul 28, 2020 at 09:48:06PM +0800, Zhiqiang Liu wrote:
> > In disassemble_status func, for dealing with selector args,
> > word is allocated by get_word func. However, word is not freed.
> > Then a memory leak occurs.
> > 
> > Here, we call FREE(word) to free word.
> 
> Err... At the risk of sounding stupid, There is a least-pending
> selector?  Hannes, you added this code (commit 35ad40b4 "leastpending
> IO
> loadbalancing is not displayed properly"). Was this a Suse thing?  Is
> it
> still a Suse thing, or have queue-length and service-time replaced
> it?

Yes, it's a "SUSE thing" (originally developed by HP). SLE15 still
supports it; I don't know if it's actually used. 
It was discussed here last year, see:
https://patchwork.kernel.org/patch/10878905/

Regards,
Martin