[dm-devel] [PATCH v2 00/10] multipath-tools: valgrind tests & fixes

Benjamin Marzinski bmarzins at redhat.com
Wed Aug 26 18:46:30 UTC 2020


On Wed, Aug 26, 2020 at 11:58:57AM +0200, mwilck at suse.com wrote:
> From: Martin Wilck <mwilck at suse.com>
> 
> Hi Christophe and Ben,
> 
> this series  adds a make target to run unit tests under valgrind, and fixes
> the issues I found using this test target.
> 
> It contains the patches I sent yesterday ([PATCH 1/5] multipath-tools tests:
> fix memory leak in alias test), but in a different order / numbering,
> which seems more appropriate now.
> 

For the set
Reviewed-by: Benjamin Marzinski <bmarzins at redhat.com>

> Regards,
> Martin
> 
> Martin Wilck (10):
>   multipath-tools: Makefile.inc: fix compilation with gcc 4.x
>   multipath-tools: Makefile: add "valgrind-test" target
>   multipath-tools tests: fix memory leak in alias test
>   multipath-tools tests: fix memory leak in hwtable test
>   multipath-tools tests: fix memory leak in vpd test
>   libmultipath: fix memory leak in ble handlers
>   libmultipath: fix enable_foreign memory leak
>   libmultipath: fix invalid memory access in is_token()
>   libmultipath: alloc_strvec: NULL-initialize strvec elements
>   libmultipath: validate_config_strvec(): avoid out-of-bounds access
> 
>  Makefile              |  3 +++
>  Makefile.inc          |  2 +-
>  libmultipath/config.c |  2 ++
>  libmultipath/dict.c   | 12 +++++++++---
>  libmultipath/parser.c | 17 +++++++++++------
>  multipath/main.c      |  2 +-
>  tests/Makefile        | 13 +++++++++++--
>  tests/README.md       |  8 ++++++++
>  tests/alias.c         |  2 ++
>  tests/hwtable.c       |  4 ++++
>  tests/vpd.c           | 18 ++++++++----------
>  11 files changed, 60 insertions(+), 23 deletions(-)
> 
> -- 
> 2.28.0




More information about the dm-devel mailing list