[dm-devel] [PATCH V4 2/5] multipathd: use daemon_status_msg to construct sd notify msg in do_sd_notify func

Martin Wilck mwilck at suse.com
Mon Aug 31 14:36:58 UTC 2020


On Mon, 2020-08-31 at 19:37 +0800, Zhiqiang Liu wrote:
> sd_notify_status() is very similar with daemon_status(), except
> DAEMON_IDLE and DAEMON_RUNNING state. As suggested by Martin,
> we can create the sd notification string in a dynamic buffer,
> and treat DAEMON_IDLE and DAEMON_RUNNING cases first. Then,
> we can use daemon_status_msg[state] for other cases.
> 
> V3->V4:
> - put "STATUS=" in format string to avoid "prefix" var as suggested
> by
> Martin.
> 
> V2->V3:
> - set MSG_SIZE to 32 and use safe_sprintf as suggested by Martin.
> 
> Signed-off-by: Zhiqiang Liu <liuzhiqiang26 at huawei.com>
> Signed-off-by: lixiaokeng <lixiaokeng at huawei.com>
> ---
>  multipathd/main.c | 33 +++++++++++----------------------
>  1 file changed, 11 insertions(+), 22 deletions(-)
> 

Thank you.
Reviewed-by: Martin Wilck <mwilck at suse.com>





More information about the dm-devel mailing list