[dm-devel] [PATCH 5/5] libmultipath: cleanup old issues with directio checker
Martin Wilck
mwilck at suse.com
Wed Feb 19 09:51:05 UTC 2020
On Wed, 2020-02-19 at 00:54 -0600, Benjamin Marzinski wrote:
> The directio checker manually aligns its directio buffer, instead of
> using posix_memalign(). It also defaults the block size for the read
> to
> 512, which may be too small for 4k devices, and it only waits for 5
> ns
> for IO completion before giving up and setting the path to pending,
> which means that in will virtually always set the path to pending on
> the
> check when the IO is issued.
>
> Signed-off-by: Benjamin Marzinski <bmarzins at redhat.com>
>
> ---
> libmultipath/checkers/directio.c | 13 ++++---------
> tests/directio.c | 1 -
> 2 files changed, 4 insertions(+), 10 deletions(-)
Reviewed-by: Martin Wilck <mwilck at suse.com>
More information about the dm-devel
mailing list