[dm-devel] [PATCH] libmultipath: fix compilation with -fno-common

[Benjamin Marzinski]

On Thu, Jan 16, 2020 at 10:55:14PM +0100, mwilck at suse.com wrote:
> From: Martin Wilck <mwilck at suse.com>


Reviewed-by: Benjamin Marzinski <bmarzins at redhat.com>
> 
> This never-used variable must be declared extern in order to avoid
> a link stage error with -fno-common.
> ---
>  libmultipath/structs.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libmultipath/structs.h b/libmultipath/structs.h
> index a3adf906..4bb567d3 100644
> --- a/libmultipath/structs.h
> +++ b/libmultipath/structs.h
> @@ -106,7 +106,7 @@ enum yes_no_undef_states {
>   * _FIND_MULTIPATHS_F must have the same value as YNU_YES.
>   * Generate a compile time error if that isn't the case.
>   */
> -char ___error1___[-(_FIND_MULTIPATHS_F != YNU_YES)];
> +extern char ___error1___[-(_FIND_MULTIPATHS_F != YNU_YES)];
>  
>  #define find_multipaths_on(conf) \
>  	(!!((conf)->find_multipaths & _FIND_MULTIPATHS_F))
> -- 
> 2.24.1