[dm-devel] [PATCH] multipath-tools: Fix compiler warnings when built without systemd.
Marius Bakke
marius at devup.no
Tue Jun 16 23:17:57 UTC 2020
Martin Wilck <mwilck at suse.com> writes:
> Hello Marius,
>
> On Sat, 2020-05-16 at 19:55 +0200, Marius Bakke wrote:
>> ---
>> libmultipath/config.c | 2 +-
>> multipathd/main.c | 19 +++++++++++++------
>> 2 files changed, 14 insertions(+), 7 deletions(-)
>>
>
> thank you for the patch, and sorry for the late reply.
> Thanks to Xose, too, for making me aware of it.
>
> This patch needs some improvements, see remarks below.
>
> In general, please note that the development and in particular the
> testing of multipath-tools has been done almost exclusively on systems
> using systemd for several years now. The compilation issues you
> encountered may only be the tip of the iceberg. In particular, the udev
> rules shipped with multipath-tools rely on systemd for proper device
> setup.
Thanks for reviewing. I'm mainly here for 'kpartx' anyway, but "good"
to know that multipath-tools may need extra care outside of systemd.
I'm hardly a C programmer, so thanks for bearing with me. Adding just
plain old ifdef guards is much clearer than sprinkling __attribute__
around.
V2 sent in a separate message.
Thanks,
Marius
More information about the dm-devel
mailing list