[dm-devel] [PATCH] dm-rq: don't call blk_mq_queue_stopped in dm_stop_queue()
Ming Lei
ming.lei at redhat.com
Fri Jun 19 08:42:14 UTC 2020
dm-rq won't stop queue, meantime blk-mq won't stop one queue too, so
remove the check.
dm_stop_queue() actually tries to quiesce hw queues via blk_mq_quiesce_queue(),
we can't check via blk_queue_quiesced for avoiding unnecessary queue
quiesce because the flag is set before synchronize_rcu() and dm_stop_queue
may be called when synchronize_rcu from another blk_mq_quiesce_queue is
in-progress.
Cc: linux-block at vger.kernel.org
Signed-off-by: Ming Lei <ming.lei at redhat.com>
---
drivers/md/dm-rq.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/md/dm-rq.c b/drivers/md/dm-rq.c
index f60c02512121..ed4d5ea66ccc 100644
--- a/drivers/md/dm-rq.c
+++ b/drivers/md/dm-rq.c
@@ -70,9 +70,6 @@ void dm_start_queue(struct request_queue *q)
void dm_stop_queue(struct request_queue *q)
{
- if (blk_mq_queue_stopped(q))
- return;
-
blk_mq_quiesce_queue(q);
}
--
2.25.2
More information about the dm-devel
mailing list