On Sat, Feb 29, 2020 at 09:04:00AM +0100, Pankaj Gupta wrote: > > + phys_addr_t pmem_off = sector * 512 + pmem->data_offset; > > minor nit, maybe 512 is replaced by macro? Looks like its used at multiple > places, maybe can keep at is for now. That would be the existing SECTOR_SIZE macro.