[dm-devel] [PATCH] dm verity fec: Fix memory leak in verity_fec_ctr

[James Bottomley]

You two broke threading on this for what looks like non-trivial
reasons.  Threading is becoming very important to us with the mbox
tools, so it's important to get right.

The original problem is that the first message id is illegal under RFC
2822:

> Message-Id:	<20200317091212.GA18241 at harshini.x.shetty@sony.com>

You can't have two @ signs in a Message-id.  However, your emailer
completely made up the in-repy-to id which should quote the original
message id:

> References: <5e70da92.1c69fb81.c30ac.5d5cSMTPIN_ADDED_BROKEN at mx.google.com>
> In-Reply-To: <5e70da92.1c69fb81.c30ac.5d5cSMTPIN_ADDED_BROKEN at mx.google.com>

Which is why threading broke.

Can you both try to fix this?  The google problem looks to be atypical
because if I look at any other mailer behaviour it will simply quote a message-id back in the In-Reply-To without checking for legality.

James