[dm-devel] [PATCH] dm-zoned: remove leftover hunk for switching to sequential zones

Damien Le Moal Damien.LeMoal at wdc.com
Fri May 22 07:45:41 UTC 2020


On 2020/05/22 16:32, Hannes Reinecke wrote:
> Remove a leftover hunk to switch from sequential zones to random

...from random zones to sequential zones...

> zones when selecting a reclaim zone; the logic has moved into the
> caller and this patch is now pointless.

s/this patch/this hunk/ ?

> 
> Fixes: 34f5affd04c4 ("dm zoned: separate random and cache zones")
> Signed-off-by: Hannes Reinecke <hare at suse.de.
> ---
>  drivers/md/dm-zoned-metadata.c | 8 --------
>  1 file changed, 8 deletions(-)
> 
> diff --git a/drivers/md/dm-zoned-metadata.c b/drivers/md/dm-zoned-metadata.c
> index db0dc2b5d44d..4a2e351365c5 100644
> --- a/drivers/md/dm-zoned-metadata.c
> +++ b/drivers/md/dm-zoned-metadata.c
> @@ -2111,14 +2111,6 @@ struct dm_zone *dmz_alloc_zone(struct dmz_metadata *zmd, unsigned long flags)
>  		 */
>  		if (!(flags & DMZ_ALLOC_RECLAIM))
>  			return NULL;
> -		/*
> -		 * Use sequential write zones if we started off with random
> -		 * zones and the list is empty
> -		 */
> -		if (list == &zmd->unmap_rnd_list) {
> -			list = &zmd->unmap_seq_list;
> -			goto again;
> -		}
>  		/*
>  		 * Fallback to the reserved sequential zones
>  		 */

Apart from the commit message nits, looks good.

Reviewed-by: Damien Le Moal <damien.lemoal at wdc.com>

-- 
Damien Le Moal
Western Digital Research






More information about the dm-devel mailing list