[dm-devel] [PATCH 1/1] libdmmp: Add support for upcoming json-c 0.14.0.

[Eric Hawicz]

On 5/29/2020 7:45 AM, Xose Vazquez Perez wrote:
> On 5/29/20 11:12 AM, Martin Wilck wrote:
>
>> Did you see
>> https://www.redhat.com/archives/dm-devel/2020-May/msg00261.html ?
>>
>> This has first been reported to the list by Christian (
>> https://www.redhat.com/archives/dm-devel/2020-April/msg00261.html), and
>> brought to my attention later by Xose. I personally thought the change
>> from boolean to int is a step in the wrong direction, therefore I
>> submitted my modified version using stdboolh. If everyone else is fine
>> with the int, it's not worth arguing about it.
>>
>> Regards,
>> Martin
>>
>> PS: Can anyone explain why json-c did this? Looks like a "cause hassle
>> for downstream devs and users for no good reason" kind of thing to
>> me...
>>
>
> Add Eric Haszlakiewicz to CC.
>
> Done at: 
> https://github.com/json-c/json-c/commit/0992aac61f8b087efd7094e9ac2b84fa9c040fcd


TRUE and FALSE are rather generic defines that json-c had no business 
ever setting, especially to json-c specific values, and the fact that we 
were doing so was conflicting with other cases that already defined it.  
Sorry about the hassle, but I consider that a very good reason to remove 
them.


Eric