[dm-devel] Thoughts about multipathd's log thread

[Martin Wilck]

On Wed, 2020-11-04 at 10:12 -0600, Benjamin Marzinski wrote:
> On Wed, Nov 04, 2020 at 03:11:04PM +0100, Hannes Reinecke wrote:
> > 
> > Well ... isn't that what the option '-d' is for?
> > Namely _not_ starting the log thread when running under systemd?
> 
> Martin is arguing that syslogd is at least as likely not to block as
> journald, so if we don't need the log thread when writing to journald
> (though stderr), we also don't need the log thread when writing to
> syslogd. Correct me, if I'm wrong Martin.

Exactly. The log thread has some race issues that we've been discussing
in another thread ("[PATCH v2 29/29] libmultipath: fix race between
log_safe and log_thread_stop()"). I had been digging into the code a
bit, and found some more things that I'd like to see improved. But I
realized fixing this for good might be hairy and take a lot of time
which would be better spent elsewhere, and started wondering if we
still need it at all.

Thanks,
Martin