[dm-devel] [PATCH 14/20] block: remove the nr_sects field in struct hd_struct

Christoph Hellwig hch at lst.de
Fri Nov 20 16:01:37 UTC 2020


On Fri, Nov 20, 2020 at 03:59:56PM +0000, Matthew Wilcox wrote:
> > Exactly.  In theory we could skip it for 64-bit, but as updating the
> > size isn't a fast path, and struct block_device isn't super size critical
> > I'd rather keep the same code for 32 vs 64-bit builds.
> 
> Is it better to switch to i_size_write() / i_size_read()?

I think we've stopped updating the size from contexts that can't block,
so it is worth pursuing. I'd rather do it after this series is done
and merged, though.




More information about the dm-devel mailing list