[dm-devel] [PATCH v2 18/29] libmultipath: fix log_thread startup and teardown

[Martin Wilck]

On Mon, 2020-10-19 at 15:00 -0500, Benjamin Marzinski wrote:
>  
> >  void log_thread_start (pthread_attr_t *attr)
> >  {
> > -	logdbg(stderr,"enter log_thread_start\n");
> > +	bool err = false;
> >  
> > -	pthread_mutex_init(&logq_lock, NULL);
> > -	pthread_mutex_init(&logev_lock, NULL);
> > -	pthread_cond_init(&logev_cond, NULL);
> 
> If you remove these initializers, then these variables are
> uninitialized. I realize that patch 29 makes them statically
> initialized, so I'm not sure how big of an issue it is.  I guess it
> depends on how much we care about the possiblity of things not
> working
> right when bisecting an issue.
> 

Thanks for pointing this out. It was a rebasing mistake. I'll fix it.

Martin