[dm-devel] [PATCH v2 24/29] libmultipath: use libmp_verbosity to track verbosity

Martin Wilck mwilck at suse.com
Mon Oct 26 14:47:11 UTC 2020


On Mon, 2020-10-19 at 15:38 -0500, Benjamin Marzinski wrote:
> On Fri, Oct 16, 2020 at 12:44:56PM +0200, mwilck at suse.com wrote:
> > From: Martin Wilck <mwilck at suse.com>
> > 
> > Introduce a new global variable to set the verbosity of
> > libmultipath.
> > This avoids accessing the configuration in every dlog() call.
> > When libmultipath reads its configuration in init_config() or
> > load_config(), it will use the current value of libmp_verbosity
> > for logging. Immediately before returning, libmp_verbosity will be
> > overwritten with the verbosity value from the configuration file,
> > if it was set there. An application is free to set libmp_verbosity
> > back to the previous value or not after that, depending on whether
> > command line options or configuration file settings should take
> > precedence.
> 
> Is there some reason why domap() and coalesce_paths() call
> print_multipath_topology() and libmp_dm_init() calls dm_init() using
> conf->verbosity instead of libmp_verbosity?

No, just an oversight. I realized this in the meantime, too.
Will fix it.

Martin





More information about the dm-devel mailing list