[dm-devel] [PATCH 4/5] libmultipath: only read 0xc9 vpd page for devices with rdac checker

[Schremmer, Steven]

> From: Benjamin Marzinski <bmarzins at redhat.com>
> Sent: Friday, October 23, 2020 4:15 PM
> 
> Cc: Steve Schremmer <sschremm at netapp.com>
> Cc: NetApp RDAC team <ng-eseries-upstream-maintainers at netapp.com>
> Signed-off-by: Benjamin Marzinski <bmarzins at redhat.com>
> ---
>  libmultipath/propsel.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libmultipath/propsel.c b/libmultipath/propsel.c
> index fa4ac5d9..90a77d77 100644
> --- a/libmultipath/propsel.c
> +++ b/libmultipath/propsel.c
> @@ -501,7 +501,7 @@ check_rdac(struct path * pp)
>         if (pp->bus != SYSFS_BUS_SCSI)
>                 return 0;
>         /* Avoid ioctl if this is likely not an RDAC array */
> -       if (__do_set_from_hwe(checker_name, pp, checker_name) &&
> +       if (!__do_set_from_hwe(checker_name, pp, checker_name) ||
>             strcmp(checker_name, RDAC))
>                 return 0;
>         len = get_vpd_sgio(pp->fd, 0xC9, 0, buff, 44);
> --
> 2.17.2

Reviewed-by: Steve Schremmer <sschremm at netapp.com>

Thanks,
Steve