[dm-devel] [PATCH 1/5] libmultipath: move fast_io_fail defines to structs.h

Martin Wilck martin.wilck at suse.com
Fri Oct 30 20:43:42 UTC 2020


On Fri, 2020-10-23 at 16:15 -0500, Benjamin Marzinski wrote:
> Since fast_io_fail is part of the multipath struct, its symbolic
> values
> belong in structs.h. Also, make it an instance of a general enum,
> which
> will be used again in future patches, and change the set/print
> functions
> which use it to use the general enum instead.
> 
> Signed-off-by: Benjamin Marzinski <bmarzins at redhat.com>

> +enum undefined_off_zero {
> +	UOZ_UNDEF = 0,
> +	UOZ_OFF = -1,
> +	UOZ_ZERO = -2,
> +};

"UOZ" sounds kind of ugly to me. Anyway:

Reviewed-by: Martin Wilck <mwilck at suse.com>

-- 
Dr. Martin Wilck <mwilck at suse.com>, Tel. +49 (0)911 74053 2107
SUSE  Software Solutions Germany GmbH
HRB 36809, AG Nürnberg GF: Felix
Imendörffer






More information about the dm-devel mailing list