[dm-devel] [PATCH 05/14] multipathd: use MALLOC and check return value in, cli_getprkey func

lixiaokeng lixiaokeng at huawei.com
Wed Sep 2 07:18:37 UTC 2020


In cli_getprkey func, we use MALLOC instead of malloc, and check
the return value of MALLOC.

Signed-off-by: Zhiqiang Liu <liuzhiqiang26 at huawei.com>
Signed-off-by: Lixiaokeng <lixiaokeng at huawei.com>
Signed-off-by: Linfeilong <linfeilong at huawei.com>
---
 multipathd/cli_handlers.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/multipathd/cli_handlers.c b/multipathd/cli_handlers.c
index 27e4574f..d345afd3 100644
--- a/multipathd/cli_handlers.c
+++ b/multipathd/cli_handlers.c
@@ -1535,7 +1535,11 @@ cli_getprkey(void * v, char ** reply, int * len, void * data)
 	if (!mpp)
 		return 1;

-	*reply = malloc(26);
+	*reply = MALLOC(26);
+	if (!*reply) {
+		condlog(0, "malloc *reply failed.");
+		return 1;
+	}

 	if (!get_be64(mpp->reservation_key)) {
 		sprintf(*reply, "none\n");
-- 




More information about the dm-devel mailing list