[dm-devel] [PATCH 00/14] multipath-tools series: some cleanups and fixes checked by codedex tool

[Martin Wilck]

Hello Lixiaokeng,

On Wed, 2020-09-02 at 14:40 +0800, lixiaokeng wrote:
> Hi:
>     Now, we check multipath-tools codes with codedex tool. Here
> are some some cleanups and fixes.

Thank you. However I'm going to nack all patches that add error
messages after unsuccesful memory allocations. Such messages are
unhelpful most of the time, and increase the code size without a true
benefit. I've actually considered to get rid of all these, and replace
them by a log_oom() macro.

See an untested prototype attached, to better understand what I mean.

Regards
Martin


-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-libmultipath-prototype-implementation-of-log_oom.patch
Type: text/x-patch
Size: 1547 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/dm-devel/attachments/20200903/d34ab10c/attachment.bin>