[dm-devel] [PATCH 12/14] libmultipathpersist: use update_multipath_table/status, in get_mpvec

lixiaokeng lixiaokeng at huawei.com
Mon Sep 7 13:26:15 UTC 2020


> Looks mostly good. I agree that we should be checking the results of
> getting the raw data before we try to disassemble it. But, there's not
> really any point to calling continue as the last operation of a loop.
> Perhaps
> 
> if (update_multipath_table(mpp, pathvec, DI_CHECKER) == DMP_OK)
> 	update_multipath_status(mpp);
> 
> makes more sense.
> 
Hi Ben,
  Thanks for your review. I will change it in patch v2.

-Lixiaokeng





More information about the dm-devel mailing list