[dm-devel] [PATCH v2 13/21] libmultipath: provide defaults for {get, put}_multipath_config

Martin Wilck mwilck at suse.com
Sat Sep 26 09:43:46 UTC 2020


On Fri, 2020-09-25 at 16:57 -0500, Benjamin Marzinski wrote:
> On Fri, Sep 25, 2020 at 10:00:10PM +0200, Martin Wilck wrote:
> > 
> > I suggest to track the verbosity independently in a different
> > variable,
> > and just set it from init_config() if it was actually set in the
> > config file. Most of the time, we set it from the command line.
> > This would have the additional benefit not to have to call
> > get_multipath_config() in dlog().
> 
> Sure. That sounds like a much simpler solution than what I was
> proposing.

I will do that in a separate patch. It will actually be a short
series with logging fixes. Would you ack this patch then?
In general it makes sense for get_multipath_config() to return NULL if
the struct config is not initialized.

Thanks,
Martin





More information about the dm-devel mailing list