[dm-devel] [PATCH v2 20/21] libmultipath (coverity): check return values in dm_get_multipath()
mwilck at suse.com
mwilck at suse.com
Wed Dec 1 12:36:49 UTC 2021
From: Martin Wilck <mwilck at suse.com>
Coverity CID 374151.
Reviewed-by: Benjamin Marzinski <bmarzins at redhat.com>
Signed-off-by: Martin Wilck <mwilck at suse.com>
---
libmultipath/devmapper.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/libmultipath/devmapper.c b/libmultipath/devmapper.c
index 1dc83df..c0eb335 100644
--- a/libmultipath/devmapper.c
+++ b/libmultipath/devmapper.c
@@ -1294,8 +1294,10 @@ struct multipath *dm_get_multipath(const char *name)
if (dm_get_map(name, &mpp->size, NULL) != DMP_OK)
goto out;
- dm_get_uuid(name, mpp->wwid, WWID_SIZE);
- dm_get_info(name, &mpp->dmi);
+ if (dm_get_uuid(name, mpp->wwid, WWID_SIZE) != 0)
+ condlog(2, "%s: failed to get uuid for %s", __func__, name);
+ if (dm_get_info(name, &mpp->dmi) != 0)
+ condlog(2, "%s: failed to get info for %s", __func__, name);
return mpp;
out:
--
2.33.1
More information about the dm-devel
mailing list