[dm-devel] [PATCH 0/5] libmpathpersist: cleanup ABI and headers

[Benjamin Marzinski]

On Thu, Dec 16, 2021 at 01:54:57PM +0100, mwilck at suse.com wrote:
> From: Martin Wilck <mwilck at suse.com>
> 
> Hi Christophe, hi Ben,
> 
> when reviewing Ben's last patch set, I noticed that the change
> of struct multipath would formally change the ABI of libmpathpersist,
> even though the public API as defined by mpath_persist.h doesn't
> reference this struct.
> 
> This set cleans this up by splitting the libmpathpersist code into a
> public part, a semi-private part (used by other multipath-tools components)
> and a private part (used by libmpathpersist alone). In the future,
> the abi check tools will detect an ABI change in cases like this, but it'll
> be easy to check whether the public or private part of the ABI is affected.
> 
> A minor version bump of the libmpathpersist version is required to reflect
> the fact that symbols have been removed from the LIBMPATHPERSIST versioned
> ABI.
> 
> The set also contains some other minor header file cleanups. No actual code
> flow is changed, only code shuffled around.
> 
> Regards
> Martin

For the set
Reviewed-by: Benjamin Marzinski <bmarzins at redhat.com>

> 
> Martin Wilck (5):
>   libmpathpersist: split public and internal API
>   multipathd: remove duplicate definitions from main.h
>   libmpathpersist/multipathd: remove duplicate definition
>   libmpathpersist: remove __STDC_FORMAT_MACROS
>   libmpathpersist: cleanup mpathpr.h
> 
>  libmpathpersist/Makefile                |   2 +-
>  libmpathpersist/libmpathpersist.version |  27 +-
>  libmpathpersist/mpath_persist.c         | 776 +----------------------
>  libmpathpersist/mpath_persist_int.c     | 792 ++++++++++++++++++++++++
>  libmpathpersist/mpath_persist_int.h     |  25 +
>  libmpathpersist/mpath_pr_ioctl.c        |   3 +-
>  libmpathpersist/mpathpr.h               |  49 +-
>  mpathpersist/main.c                     |   1 +
>  multipathd/main.c                       |   5 +-
>  multipathd/main.h                       |  15 +-
>  10 files changed, 848 insertions(+), 847 deletions(-)
>  create mode 100644 libmpathpersist/mpath_persist_int.c
>  create mode 100644 libmpathpersist/mpath_persist_int.h
> 
> -- 
> 2.34.1