[dm-devel] [PATCH] dm-verity: Fix FEC for RS roots non-aligned to block size

Milan Broz gmazyland at gmail.com
Tue Feb 23 10:57:07 UTC 2021


On 23/02/2021 04:00, Jérôme Carretero wrote:
> Tested-by: Jérôme Carretero <cJ-ko at zougloub.eu>
> 
> 
> I smoke-tested by fuzzing contiguous ranges of user data (not hash
> tree) and correction works up to the amount of added correction (since
> erasures are identified by hashes).

Thanks for testing!

> Since the fix looks obvious, this should probably CC to stable?

Yes, I forgot to add the tag, I think this should go to all stable kernels.

(It only needs dm_bufio_set_sector_offset() that was added later than FEC, IIRC.)

Milan

p.s.
There are also bugs in userspace veritysetup if FEC has hash area is stored
on the same device, then code miscalculates parity bytes then.
This will be fixed soon in next stable cryptsetup release.




More information about the dm-devel mailing list