[dm-devel] dm-integrity: fix the maximum number of arguments

[Mikulas Patocka]

On Tue, 12 Jan 2021, Mike Snitzer wrote:

> On Tue, Jan 12 2021 at  2:54pm -0500,
> Mikulas Patocka <mpatocka at redhat.com> wrote:
> 
> > Advance the maximum number of arguments to 15.
> > 
> > Signed-off-by: Mikulas Patocka <mpatocka at redhat.com>
> > Cc: stable at vger.kernel.org	# v4.19+
> > 
> > ---
> >  drivers/md/dm-integrity.c |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > Index: linux-2.6/drivers/md/dm-integrity.c
> > ===================================================================
> > --- linux-2.6.orig/drivers/md/dm-integrity.c	2021-01-12 20:45:23.000000000 +0100
> > +++ linux-2.6/drivers/md/dm-integrity.c	2021-01-12 20:46:15.000000000 +0100
> > @@ -3792,7 +3792,7 @@ static int dm_integrity_ctr(struct dm_ta
> >  	unsigned extra_args;
> >  	struct dm_arg_set as;
> >  	static const struct dm_arg _args[] = {
> > -		{0, 9, "Invalid number of feature args"},
> > +		{0, 15, "Invalid number of feature args"},
> >  	};
> >  	unsigned journal_sectors, interleave_sectors, buffer_sectors, journal_watermark, sync_msec;
> >  	bool should_write_sb;
> 
> Can you please expand on which args weren't accounted for?

The kernel 4.19 added "meta_device" 
(356d9d52e1221ba0c9f10b8b38652f78a5298329) and "recalculate" 
(a3fcf7253139609bf9ff901fbf955fba047e75dd) flags.

The commit 468dfca38b1a6fbdccd195d875599cb7c8875cd9 added 
"sectors_per_bit" and "bitmap_flush_interval".

The commit 84597a44a9d86ac949900441cea7da0af0f2f473 added 
"allow_discards".

The commit d537858ac8aaf4311b51240893add2fc62003b97 added "fix_padding".

> Which commit introduced the problem? (I'd like a "Fixes:" reference)
> 
> Thanks,
> Mike

Mikulas