[dm-devel] [PATCH 0/3] Multipath io_err_stat fixes
Martin Wilck
martin.wilck at suse.com
Wed Jan 13 11:45:55 UTC 2021
On Tue, 2021-01-12 at 17:52 -0600, Benjamin Marzinski wrote:
> I found an ABBA deadlock in the io_err_stat marginal path code, and
> in
> the process of fixing it, noticed a potential crash on shutdown. This
> patchset addresses both of the issues.
>
> Benjamin Marzinski (3):
> libmultipath: make find_err_path_by_dev() static
> multipathd: avoid io_err_stat crash during shutdown
> multipathd: avoid io_err_stat ABBA deadlock
>
> libmultipath/io_err_stat.c | 159 +++++++++++++++++------------------
> --
> 1 file changed, 73 insertions(+), 86 deletions(-)
>
Thanks, the series looks good, I have only minor nits.
I've made some remarks about the io_err_stat code in the review. While
you're working at it, would you be willing to fix those issues too?
Cheers,
Martin
--
Dr. Martin Wilck <mwilck at suse.com>, Tel. +49 (0)911 74053 2107
SUSE Software Solutions Germany GmbH
HRB 36809, AG Nürnberg GF: Felix Imendörffer
More information about the dm-devel
mailing list