[dm-devel] [PATCH v3 0/1] Multipath io_err_stat fixes

[Martin Wilck]

On Mon, 2021-01-18 at 22:46 -0600, Benjamin Marzinski wrote:
> I found an ABBA deadlock in the io_err_stat marginal path code, and
> in
> the process of fixing it, noticed a potential crash on shutdown. This
> patchset addresses both of the issues.
> 
> Changes from v2:
> 
> 0001: This is patch 0006 from v2. It is exactly the same code. But
> the
> commit message now mentions that check_path() no longer switches
> paths
> from delayed to pending.
> 
> Changes from v1:
> 
> 0002: use cleanup_mutex instead of cleanup_unlock as suggested by
> Martin
> 
> 0003: add pthread_testcancel and use cleanup_mutex instead of
> cleanup_unlock as suggested by Martin. Also, make tmp_pathvec a
> constant
> pointer, since it should always equal _pathvec.
> 
> 0004-0006 are new patches to deal with io_err_stat issues from
> Martin's
> review
> 
> 
> Benjamin Marzinski (1):
>   multipathd: cleanup logging for marginal paths
> 
>  libmultipath/io_err_stat.c |  7 +++----
>  multipathd/main.c          | 25 ++++++++++++++-----------
>  2 files changed, 17 insertions(+), 15 deletions(-)
> 

Thanks a lot for adding the explanation.
For the whole 6-part series:

Reviewed-by: Martin Wilck <mwilck at suse.com>

Pushed to "queue" branch.

-- 
Dr. Martin Wilck <mwilck at suse.com>, Tel. +49 (0)911 74053 2107
SUSE Software Solutions Germany GmbH
HRB 36809, AG Nürnberg GF: Felix Imendörffer