[dm-devel] [kbuild] Re: [PATCH v4 2/3] scsi: scsi_ioctl: add sg_io_to_blk_status()
Dan Carpenter
dan.carpenter at oracle.com
Tue Jun 29 07:00:10 UTC 2021
Hi,
url: https://github.com/0day-ci/linux/commits/mwilck-suse-com/scsi-dm-dm_blk_ioctl-implement-failover-for-SG_IO-on-dm-multipath/20210628-175410
base: https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next
config: xtensa-randconfig-s032-20210628 (attached as .config)
compiler: xtensa-linux-gcc (GCC) 9.3.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# apt-get install sparse
# sparse version: v0.6.3-341-g8af24329-dirty
# https://github.com/0day-ci/linux/commit/259453ca972ae531cfdca07cbf4d6bb09b8f8c9f
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review mwilck-suse-com/scsi-dm-dm_blk_ioctl-implement-failover-for-SG_IO-on-dm-multipath/20210628-175410
git checkout 259453ca972ae531cfdca07cbf4d6bb09b8f8c9f
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=xtensa SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp at intel.com>
sparse warnings: (new ones prefixed by >>)
>> block/scsi_ioctl.c:937:24: sparse: sparse: dubious: !x & y
vim +937 block/scsi_ioctl.c
259453ca972ae5 Martin Wilck 2021-06-28 932 blk_status_t sg_io_to_blk_status(struct sg_io_hdr *hdr)
259453ca972ae5 Martin Wilck 2021-06-28 933 {
259453ca972ae5 Martin Wilck 2021-06-28 934 int result;
259453ca972ae5 Martin Wilck 2021-06-28 935 blk_status_t sts;
259453ca972ae5 Martin Wilck 2021-06-28 936
259453ca972ae5 Martin Wilck 2021-06-28 @937 if (!hdr->info & SG_INFO_CHECK)
^
Should be if (!(hdr->info & SG_INFO_CHECK))
259453ca972ae5 Martin Wilck 2021-06-28 938 return BLK_STS_OK;
259453ca972ae5 Martin Wilck 2021-06-28 939
259453ca972ae5 Martin Wilck 2021-06-28 940 result = hdr->status |
259453ca972ae5 Martin Wilck 2021-06-28 941 (hdr->msg_status << 8) |
259453ca972ae5 Martin Wilck 2021-06-28 942 (hdr->host_status << 16) |
259453ca972ae5 Martin Wilck 2021-06-28 943 (hdr->driver_status << 24);
259453ca972ae5 Martin Wilck 2021-06-28 944
259453ca972ae5 Martin Wilck 2021-06-28 945 sts = __scsi_result_to_blk_status(&result, result);
259453ca972ae5 Martin Wilck 2021-06-28 946 hdr->host_status = host_byte(result);
259453ca972ae5 Martin Wilck 2021-06-28 947
259453ca972ae5 Martin Wilck 2021-06-28 948 return sts;
259453ca972ae5 Martin Wilck 2021-06-28 949 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
_______________________________________________
kbuild mailing list -- kbuild at lists.01.org
To unsubscribe send an email to kbuild-leave at lists.01.org
More information about the dm-devel
mailing list