[dm-devel] [PATCH v2 2/3] libmultipath: cleanup uid_attribute checking code

Martin Wilck martin.wilck at suse.com
Thu Mar 11 20:09:22 UTC 2021


On Wed, 2021-02-24 at 00:33 -0600, Benjamin Marzinski wrote:
> In get_uid(), if pp->getuid is NULL, multipath will check the
> pp->uid_attribute to get the wwid.  If pp->uid_attribute is NULL,
> nothing will happen in that block of code, because both
> udev_available
> and has_uid_fallback() are false if pp->uid_attribute is NULL. So
> instead of multiple checks if pp->uid_attribute is NULL, just check
> once
> for the code block.
> 
> Signed-off-by: Benjamin Marzinski <bmarzins at redhat.com>

Reviewed-by: Martin Wilck <mwilck at suse.com>





More information about the dm-devel mailing list