[dm-devel] [PATCH] Revert "multipath -U: reduce log level of "adding new path" message"

Benjamin Marzinski bmarzins at redhat.com
Mon Mar 22 14:37:39 UTC 2021


On Fri, Mar 19, 2021 at 05:26:47PM +0100, mwilck at suse.com wrote:
> From: Martin Wilck <mwilck at suse.com>
> 
> After "11-dm-mpath.rules: run "multipath -U" with -v1", this patch isn't
> necessary any more. It's desirable to see these messages from multipathd,
> as they mean that a valid path had been found in a map that wasn't present
> in the udev db.
> 
Reviewed-by: Benjamin Marzinski <bmarzins at redhat.com>

And I'm fine with you rebasing the queue branch.

> Signed-off-by: Martin Wilck <mwilck at suse.com>
> ---
> If this is approved, unless anyone objects, I'll simply drop the patch
> that this reverts in the "queue" branch, performing a rebase.
> 
> ---
>  libmultipath/structs_vec.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libmultipath/structs_vec.c b/libmultipath/structs_vec.c
> index 0b069f4..d242c06 100644
> --- a/libmultipath/structs_vec.c
> +++ b/libmultipath/structs_vec.c
> @@ -192,7 +192,7 @@ bool update_pathvec_from_dm(vector pathvec, struct multipath *mpp,
>  						must_reload = true;
>  						continue;
>  					}
> -					condlog(3, "%s: adding new path %s",
> +					condlog(2, "%s: adding new path %s",
>  						mpp->alias, pp->dev);
>  					store_path(pathvec, pp);
>  					pp->tick = 1;
> -- 
> 2.30.1




More information about the dm-devel mailing list