[dm-devel] [PATCH] multipath-tools: add NVME/Huawei-XSG1 to hwtable

[Martin Wilck]

On Fri, 2021-03-26 at 00:00 +0100, Xose Vazquez Perez wrote:
> Info from: 
> https://download.huawei.com/edownload/e/download.do?actionFlag=download&nid=EDOC1100154490&partNo=6001&mid=SUPE_DOC&_t=1612885603000
> 
> Cc: Zou Ming <zouming.zouming at huawei.com>
> Cc: Martin Wilck <mwilck at suse.com>
> Cc: Benjamin Marzinski <bmarzins at redhat.com>
> Cc: Christophe Varoqui <christophe.varoqui at opensvc.com>
> Cc: DM-DEVEL ML <dm-devel at redhat.com>
> ---
>  libmultipath/hwtable.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
> index 58fa7387..7923abba 100644
> --- a/libmultipath/hwtable.c
> +++ b/libmultipath/hwtable.c
> @@ -1084,6 +1084,15 @@ static struct hwentry default_hw[] = {
>                 .pgpolicy      = GROUP_BY_PRIO,
>                 .prio_name     = PRIO_ALUA,
>         },
> +       {
> +               /* OceanStor NVMe */
> +               .vendor        = "NVME",
> +               .product       = "Huawei-XSG1",
> +               .pgpolicy      = MULTIBUS,
> +               .checker_name  = DIRECTIO,
> +               .retain_hwhandler = RETAIN_HWHANDLER_OFF,

This is a rather pointless setting, in particular if hardware_handler
is not set, and even more so for NVMe. Even for SCSI, no recent kernel
will allow changing the hwhandler.

Regards,
Martin