[dm-devel] [PATCH 3/7] github workflows: add containerized / multi-arch tests

[Benjamin Marzinski]

On Tue, Mar 30, 2021 at 11:00:56AM +0200, Martin Wilck wrote:
> On Mon, 2021-03-29 at 22:23 -0500, Benjamin Marzinski wrote:
> > On Fri, Mar 26, 2021 at 10:29:40PM +0100, mwilck at suse.com wrote:
> > > 
> > > Tell me if you want this in the multipath-tools repo, and if you're
> > > ok
> > > with hosting the images in my docker hub repo.
> > 
> > I don't have problems with this setup. I haven't really looked into
> > github actions, and so really don't know how easy it setup rules to run
> > actions on events other that pushes, pull requests, etc. It seems
> > reasonable to store those in a seperate repository. It would probably
> > be
> > good to have Christophe weigh in as well before adding these. Although
> > I
> > suppose it's always possible to disable these actions in other repos.
> 
> The events and branches are specified in the job file (YAML file). When
> an event occurs on a github repository, github looks at the associated
> commit (SHA), and considers the workflows _included in the tree for
> this commit_. AFAIU, for "push" events, this means that if a branch B
> is pushed with tip commit C, only workflows that exist in C _and_
> reference branch B will be run.
> (see https://docs.github.com/en/actions/reference/events-that-trigger-workflows)
> 
> @Christophe, you will need to consider how he would like to set this up
> in your repo. Different repos may have different policies, and it's
> possible that you'll have to tweak or amend when you merge pull
> requests from myself or other people that include changes to github
> actions. For example, you may want to run CI on a different selection
> of branches. I currently have little need for CI runs on pull requests,
> but for you, that may be exactly what you need. Thinking about it, I'll
> add pull-request triggers.


I believe that you can make github check and only run actions on
specific repositories, so Christophe could have different policies,
while still using the same yaml file.

-Ben

> 
> In general, I will separate github related changes from other code
> changes, as discussed before. The reason I didn't in this patch set was
> that I wanted to advertise my github-action-related work ;-)
> 
> Cheers,
> Martin
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
>