[dm-devel] [PATCH] multipathd: fix compilation issue with liburcu < 0.8

[Martin Wilck]

On Thu, 2021-05-13 at 11:35 -0500, Benjamin Marzinski wrote:
> > 
> > diff --git a/multipathd/Makefile b/multipathd/Makefile
> > index d053c1e..dc7eb32 100644
> > --- a/multipathd/Makefile
> > +++ b/multipathd/Makefile
> > @@ -16,6 +16,8 @@ LDFLAGS += $(BIN_LDFLAGS)
> >  LIBDEPS += -L$(multipathdir) -lmultipath -L$(mpathpersistdir) -
> > lmpathpersist \
> >            -L$(mpathcmddir) -lmpathcmd -ludev -ldl -lurcu -lpthread
> > \
> >            -ldevmapper -lreadline
> > +CFLAGS += $(shell pkg-config --modversion liburcu 2>/dev/null | \
> > +       awk -F. '{ printf("-DURCU_VERSION=0x%06x\n", 256 * ( 256 *
> > $$1 + $$2) + $$3); }')
> 
> Shouldn't this be
> 
> $(shell $(PKGCONFIG) --modversion ...

Thanks for spotting that.

Martin